fscanf() returns negative value

Question

0.00/5 (No votes)

See more:

I am using fscanf() function to read data line by line from a text file. It was functioning fine but suddenly I don't know what mistake I made and now the function returns a negative value. below is my code snippet:

C#

FILE *fp;
char ip[16];
int port;

fp = fopen("ClientInformation.txt", "r"); //open the file

//Finding the Size of the file
int size = -1;
fseek (fp, 0, SEEK_END);
size=ftell (fp);

if(size > 0) //proceed only if the file is not empty
   {
      while (fscanf(fp, " %s %d", ip, &port) > 0)
         {
            //scanf() successful
         }
   }

[edit]fixed code block[/edit]

Posted 1-Apr-13 20:55pm

ayesha hassan

Updated 1-Apr-13 22:50pm

Nelek

v5

Add a Solution

2 solutions

Solution 1

[This post is not an answer and should be removed — SA]

Adding rewind(fp) just before fscanf() solved the problem :)

Posted 1-Apr-13 21:13pm

ayesha hassan

Updated 19-Apr-13 19:10pm

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

nv3 · Accepted Answer · 2013-04-01T22:20:00

This is a good example of how NOT to do things. It starts with a typo in the essential word in the title of your post. The code you presented here has no reasonable indenting. And foremost, you are demonstrating bad programming techniques. There are easier methods of finding the length of a file than doing a character-by-character loop over its contents. If you had used one of those, you wouldn't have run into your problem in the first place.

The code in

C++

if(size > 0)
{
    while (fscanf(fp, " %s %d", ip, &port) > 0)
    {
        MessageBox (NULL, "fscanf() Successful", "SUCCESS!",
            MB_ICONINFORMATION);
    }
}

could be much simpler. The outer if-construct is totally useless. Your while loop will cover the case that the file is emply anyway. So, there is actually no need to determine the file length in the first step.

If it took you just 20 minutes to find the problem in your code, why did you post the question at all? I would have expected that you took so much thought before even posting a question.