Wpf relaycommand assignment

Question

0.00/5 (No votes)

See more:

Hi,

Would just like to know if the below is a Valid way to assign a method to an ICommand.

public RelayCommand<object> CommandName
{
    get 
    {
       return new RelayCommand<object>(methodname);
    }
}

// or anonymously
public RelayCommand<object> CommandName
{
    get 
    {
       return new RelayCommand<object>(o =>
       {

       });
    }
}

What I have tried:

I'm currently doing this

public RelayCommand CommandName { get; private set; }

// Called from Constructor
private void SetupCommands()
{
    CommandName = new RelayCommand<object>(methodname);
    
    // or anonymously
    CommandName = new RelayCommand(o =>
    {

    });
}

Posted 15-Mar-20 11:58am

Member 14773636

Updated 16-Mar-20 6:54am

Add a Solution

Comments

[no name] 16-Mar-20 10:55am

If it "works", it's valid.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

George Swan · Answer 1 · 2020-03-16T06:54:00

My preference is to use the ICommand interface where possible rather than a class that implements the interface. The technique results in more loosely coupled code. Something like this.

C#

private ICommand cancelCommand;
public ICommand CancelCommand
 {
  get
   {
    return cancelCommand ?? (cancelCommand = new RelayCommand(MyCancelMethod));
   }
 }

By using the null-coalescing operator there is no need for a 'setter' and the RelayCommand is instantiated where it is used rather than in a constructor.