How to Write the query

Question

4.00/5 (1 vote)

See more:

C#

con.Open();
     SqlCommand cmd2 = new SqlCommand("Update diesel set SNO = '" + cb_sno.Text + "',Date = '" + dateTimePicker1.Text + "',Dieselcost = " + textBox1.Text + ",Dieselservice=" + txt_dieselservice.Text + ",Servicetax= " + txt_servicetax.Text + ",Educess = " + txt_educess.Text + ",Addcess = " + txt_addcess.Text + ",Sertax= " + txt_sertaxtot.Text + ",Totbill= " + txt_totbillvalue.Text + ",Flag='" + checkedListBox1.Text + "' where SNO =  " + cb_sno.Text + " and Flag ="TRUE"", con);
   cmd2.ExecuteNonQuery();
   con.Close();

When I inserting data error occurs.

please help me.

from the above what is the problem.

Posted 18-Nov-12 22:13pm

Member 8054539

Updated 18-Nov-12 22:25pm

André Kraak

v2

Add a Solution

Comments

Bitla Phanindra 19-Nov-12 4:17am

Check if the datatypes of the table's coulmns are matching in the query. If not, use proper Convert statements accordingly.

MT_ 19-Nov-12 4:17am

You can display in an alert cmd2.Tostring() and try to run the queyr in the SSMS, that will give clue. Mostly one extra or missing ' - Milind

Bitla Phanindra 19-Nov-12 4:18am

What error message do u get when you run this??

3 solutions

Solution 2

Hi,

See the code snippet "and Flag = "TRUE""

Here if you want to use double quote then you should use like \" other wise it will treat as an extra string.

Posted 18-Nov-12 22:24pm

Mohd. Mukhtar

Solution 3

You can try Batch update...
And hope this link can help you...

http://www.jarloo.com/c-bulk-upsert-to-sql-server-tutorial/[^]

http://www.java2s.com/Tutorial/CSharp/0560__ADO.Net/BatchUpdateDemo.htm[^]

http://social.msdn.microsoft.com/Forums/eu/csharplanguage/thread/d0454666-1a7d-4c17-8c96-270b99ca4e4e[^]

Posted 18-Nov-12 22:27pm

lailailaihou

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2012-11-18T22:22:00

It could be anything, starting from a space character in one of your text boxes on up.
Please don't do it like that - you leave yourself wide open to an SQL Injection attack as well as to problems like this. Use a parametrized query instead:

C#

SqlCommand cmd2 = new SqlCommand("Update diesel set SNO = @SNO,Date = @DAT,...", con);
cmd2.Parameters.AddWithValue("@SNO", cb_sno.Text);
cmd2.Parameters.AddWithValue("@DAT", dateTimePicker1.Value);
...
cmd2.ExecuteNonQuery();

It also makes the code a whole lot more readable.