where is the error in this query

Question

0.00/5 (No votes)

See more:

SQL

select reg.nregisterid as RegNo,reg.semailid as Email,reg.ntradingoptionname as TradingOption,toperiod.ntradingoptionperiod as Period,reg.totalamount as Total,suserstatus as Status 
from tbregistermember as reg 
JOIN tbuserstatus as s on reg.nuserstatusid=s.nuserstatusid 
JOIN tbtradingoptionperiod as toperiod on reg.ntradingoptionperiodid=toperiod.ntradingoptionperiodid 
where dregistrationdate between " + frmdate.Text + "
and " + todate.Text + " 
and reg.nuserstatusid = " + Ddlstatus.SelectedValue + "

Posted 22-May-12 19:40pm

kirans333

Updated 22-May-12 19:42pm

Wendelius

v2

Add a Solution

Comments

Wendelius 23-May-12 1:42am

It would help a lot if you post the error message you get

5 solutions

Solution 2

put alias name before "dregistrationdate" and " +"'"+ frmdate.Text +"'"+" and " +"'"+ todate.Text +"'"+ "

Posted 22-May-12 19:50pm

pankaj hirapara

Solution 3

Missing alias name of dregistrationdate coloumn

Posted 22-May-12 20:14pm

sunandandutt

Solution 4

you write your where condition of date between:-
where dregistrationdate between " + frmdate.Text + "
and " + todate.Text + "

instead of write like this :-

SQL

where dregistrationdate between '" + frmdate.Text + "' and
'" + todate.Text + "'

use '"+ +"' for date not use "+ +".
it will work.

Posted 24-May-12 0:31am

Prosan

Solution 5

replace your query with this

select reg.nregisterid as RegNo,reg.semailid as Email,reg.ntradingoptionname as TradingOption,toperiod.ntradingoptionperiod as Period,reg.totalamount as Total,suserstatus as Status from tbregistermember as reg JOIN tbuserstatus as s on reg.nuserstatusid=s.nuserstatusid JOIN tbtradingoptionperiod as toperiod on reg.ntradingoptionperiodid=toperiod.ntradingoptionperiodid where dregistrationdate between '" + frmdate.Text + "' and '" + todate.Text + "' and reg.nuserstatusid = " + Ddlstatus.SelectedValue

its a good practise to use parameterized queries so that you will be out of sqlinjection attacks.

Posted 24-May-12 0:38am

hitech_s

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Accepted Answer · 2012-05-22T19:44:00

Solution 1

One possible error is coming from your input. If the text boxes have for example illegal characters etc you will see an error message.

Concatenating literal values to an SQL statement is considered a bad habit. The reason is that you're vulnerable to SQL injections, data type mismatches and so on.

Instead of adding the values directly to your SQL statement, use SqlParameter[^]

Posted 22-May-12 19:44pm

Wendelius

Comments

VJ Reddy 23-May-12 1:45am

Good suggestion. 5!

Wendelius 23-May-12 2:08am

Thanks :)