extra in query expression error

Question

0.00/5 (No votes)

See more:

C#

OleDbCommand cmd = new OleDbCommand("select * from patientdetail where refby=@refby AND datep BETWEEN @date1 AND @date2)", con);           
            OleDbDataAdapter da = new OleDbDataAdapter();
            da.SelectCommand = cmd;

            cmd.Parameters.Add(new OleDbParameter("@date1", dateTimePickerstart.Value.ToShortDateString()));
            cmd.Parameters.Add(new OleDbParameter("@date2", dateTimePickerend.Value.ToShortDateString()));
            cmd.Parameters.Add(new OleDbParameter("@refby", cmbboxdocname.Text));

I am trying to execute this code.. but this code give me error "Extra ) in query expression 'refby=@refby AND datep BETWEEN @date1 AND @date2)'."

'refby' is a doctor name in 'patientdetail' table. i want to search all records between date where doctor name (refby) match.

Please give me a proper solution for searching.

Sorry for my bad english Hope you understand what i am saying.

Thanks in advance.

Posted 24-Feb-12 2:03am

varuncodee

Add a Solution

3 solutions

Solution 1

The error message is straight forward. Your query has an extra ) towards the end.

This should be correct.

C#

OleDbCommand cmd = new OleDbCommand("select * from patientdetail where refby=@refby AND datep BETWEEN @date1 AND @date2", con);

Posted 24-Feb-12 2:13am

Jyothikarthik_N

Comments

varuncodee 24-Feb-12 8:33am

Thank you very much sir.

But this query is not giving me desire result when i select dateTimePickerstart as 2/7/2011 and dateTimePickerend as 2/8/2011 and it return all records between Feb 8 to Feb 9 without matching doctor name (refby). can we use two AND operator in a query?

[no name] 24-Feb-12 20:27pm

Absolutely

Solution 3

Your code:

OleDbCommand cmd = new OleDbCommand("select * from patientdetail where refby=@refby AND datep BETWEEN @date1 AND @date2)", con);

You seem to have added an extra ')' at the end of you selection. Remove it and it should work.

Try:

OleDbCommand cmd = new OleDbCommand("select * from patientdetail where refby=@refby AND datep BETWEEN @date1 AND @date2", con);

Posted 24-Feb-12 2:17am

morhen77

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Drazen Pupovac · Accepted Answer · 2012-02-24T02:14:00

Solution 2

Try to remove ")" form:

C#

OleDbCommand cmd = new OleDbCommand("select * from patientdetail where refby=@refby AND datep BETWEEN @date1 AND @date2)", con);

to look like this:

C#

OleDbCommand cmd = new OleDbCommand("select * from patientdetail where refby=@refby AND datep BETWEEN @date1 AND @date2", con);

Posted 24-Feb-12 2:14am

Drazen Pupovac

Comments

varuncodee 24-Feb-12 8:44am

Thank you very much sir.

But this query is not giving me desire result when i select dateTimePickerstart as 2/7/2011 and dateTimePickerend as 2/8/2011 and it return all records between Feb 8 to Feb 9 without matching doctor name (refby). can we use two AND operator in a query?

Drazen Pupovac 24-Feb-12 9:05am

From my experience your query is good.
You can improve him like this (but i think this will not change nothing):

select * from patientdetail where (refby=@refby) AND (datep BETWEEN @date1 AND @date2)

my recommendation is to use Management Studio (or some other tool) and execute query directly and you will see what's happening.

varuncodee 24-Feb-12 9:49am

yes sir query is correct, actually datatype of "date" Field is set to "Text" that's why query was not giving me desired result but now it's working.
Thank alot for helping me :)