Getting error while inserting a record

Question

0.00/5 (No votes)

See more:

C#

public int Insert(Student s)
       {
           con.Open();
           cmd = new SqlCommand("Insert into Students (stdid, studname) values" + "(@stdid, @studname)", con);
           SqlParameter[] prm = new SqlParameter[2];
           prm[0] = new SqlParameter("@stdid",SqlDbType.Int);
           prm[1] = new SqlParameter("@studname", SqlDbType.VarChar, 50);
           prm[0].Value = s.studentid;
           prm[1].Value = s.studentname;
           cmd.CommandType = CommandType.Text;
           return cmd.ExecuteNonQuery();

       }

I am getting error like this.

Must declare the scalar variable "@stdid".

Posted 23-Dec-11 21:07pm

sreekanth12

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Answer 1 · 2011-12-23T21:19:00

Solution 1

You don't add the parameters to the command, so add to your code:

C#

...
cmd.Parameters.Add(prm[0]);
cmd.Parameters.Add(prm[1]);
...

Posted 23-Dec-11 21:19pm

Wendelius

Comments

Monjurul Habib 24-Dec-11 3:24am

5!

Wendelius 24-Dec-11 3:28am

Thanks :)

OriginalGriff · Answer 2 · 2011-12-23T21:20:00

You declare a new parameters block, but you don't use it!
Try:

C#

public int Insert(Student s)
{
    con.Open();
    cmd = new SqlCommand("Insert into Students (stdid, studname) values" + "(@stdid, @studname)", con);
    // SqlParameter[] prm = new SqlParameter[2];
    // prm[0] = new SqlParameter("@stdid",SqlDbType.Int);
    // prm[1] = new SqlParameter("@studname", SqlDbType.VarChar, 50);
    // prm[0].Value = s.studentid;
    // prm[1].Value = s.studentname;
    cmd.Parameters.AddWithValue("@stdid", s.studentid);
    cmd.Parameters.AddWithValue("@studname", s.studentname);
    cmd.CommandType = CommandType.Text;
    return cmd.ExecuteNonQuery();
 }

Note that Parameters.Add (which you are effectively using) is depreciated in favour of AddWithValue, as shown above.

Monjurul Habib · Answer 3 · 2011-12-23T21:24:00

Solution 3

Try following:
Creating SqlParameters Best Practices
C# SqlParameter Example
C# SQL INSERT

Posted 23-Dec-11 21:24pm

Monjurul Habib

Comments

Wendelius 24-Dec-11 3:28am

Good examples, 5

Monjurul Habib 24-Dec-11 3:30am

thank you