What am i doing wrong?

Question

1.00/5 (1 vote)

See more:

Hi,
I am a newbie and am learning both sql and programming.....i tried to write a code which calls a stored procedure from which it gets the record and displays, i dont know where im going wrong.......
The stored procedure is

SQL

create PROCEDURE [dbo].[profdata]
	@username nvarchar (50) OUTPUT, 
	@password nvarchar (50) output,
	@firstname NVARCHAR(50) output,
    @lastname NVARCHAR(50) output,
    @email NVARCHAR(50) OUTPUT
AS
BEGIN
	
	SET NOCOUNT ON;

SELECT * FROM PROFILE WHERE USERNAME=@Username

END

Do i need to add something next to select so that it can return the values to the calling variable?

Here is the code in C#

C#

string sCon = ConfigurationManager.AppSettings["ConString"];
           SqlConnection con = new SqlConnection(sCon);
           SqlParameter p1 = new SqlParameter("@Username", SqlDbType.NChar);
           SqlParameter p2 = new SqlParameter("@Password", SqlDbType.NChar);
           SqlParameter p3 = new SqlParameter("@FirstNAME ", SqlDbType.NChar);
           SqlParameter p4 = new SqlParameter("@LastName", SqlDbType.NChar);
           SqlParameter p5 = new SqlParameter("@EMail", SqlDbType.NChar);
           //p1.Direction = ParameterDirection.Output;
           p1.Direction = ParameterDirection.InputOutput;
           p2.Direction = ParameterDirection.Output;
           p3.Direction = ParameterDirection.Output;
           p4.Direction = ParameterDirection.Output;
           p5.Direction = ParameterDirection.Output;
           con.Open();
           SqlCommand cmd = new SqlCommand();
           cmd.Parameters.Add(p1);
           cmd.Parameters.Add(p2);
           cmd.Parameters.Add(p3);
           cmd.Parameters.Add(p4);
           cmd.Parameters.Add(p5);
           cmd.CommandType = CommandType.StoredProcedure;
           cmd.CommandText = "profdata";
           cmd.Connection = con;
           con.Close();
          p1.Value = TextBox1.Text;
          p2.Value = TextBox2.Text;
          p3.Value = TextBox3.Text;
          p4.Value = TextBox4.Text;
          p5.Value = TextBox5.Text;

I know its kind of basic but i dont know where im making the mistaking, thanks in advance for clarifying.

Thanks for the link guys but i dont see anything regarding returning of value from the stored procedure to the function that called it. i even tried adding

SQL

SET @lastname = (SELECT [Last Name] FROM PROFILE WHERE @username=Username)
SET @firstname = (SELECT [First Name] FROM PROFILE WHERE @username=Username)
SET @email = (SELECT [E-Mail] FROM PROFILE WHERE @username=Username)

to the stored procedure but still i am getting

Object reference not set to an instance of an object.

i know that im doing something wrong at assigning the returned values.....
any help is appreciated...

C#

p1.Value = TextBox1.Text;
p2.Value = TextBox2.Text;
p3.Value = TextBox3.Text;
p4.Value = TextBox4.Text;
p5.Value = TextBox5.Text;

--
Regards
Prasanth

Posted 3-Aug-11 21:06pm

Prasanth Vignesh

Updated 3-Aug-11 21:41pm

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

sudeshchandram · Answer 1 · 2011-08-03T21:32:00

I have corrected your code, Please try this,

C#

string sCon = ConfigurationManager.AppSettings["ConString"];

      SqlConnection con = new SqlConnection(sCon);
      SqlParameter p1 = new SqlParameter("@Username", SqlDbType.NVarChar,50);
      SqlParameter p2 = new SqlParameter("@Password", SqlDbType.NVarChar, 50);
      SqlParameter p3 = new SqlParameter("@FirstNAME ", SqlDbType.NVarChar, 50);
      SqlParameter p4 = new SqlParameter("@LastName", SqlDbType.NVarChar, 50);
      SqlParameter p5 = new SqlParameter("@EMail", SqlDbType.NVarChar, 50);
            //p1.Direction = ParameterDirection.Output;
            p1.Direction = ParameterDirection.InputOutput;
            p2.Direction = ParameterDirection.Output;
            p3.Direction = ParameterDirection.Output;
            p4.Direction = ParameterDirection.Output;
            p5.Direction = ParameterDirection.Output;
            con.Open();
            SqlCommand cmd = new SqlCommand();
            cmd.Parameters.Add(p1);
            cmd.Parameters.Add(p2);
            cmd.Parameters.Add(p3);
            cmd.Parameters.Add(p4);
            cmd.Parameters.Add(p5);
            cmd.CommandType = CommandType.StoredProcedure;
            cmd.CommandText = "profdata";
            cmd.Connection = con;
            
            p1.Value = TextBox1.Text;
           p2.Value = TextBox2.Text;
           p3.Value = TextBox3.Text;
           p4.Value = TextBox4.Text;
           p5.Value = TextBox5.Text;

            cmd.ExecuteNonQuery();

           TextBox3.Text = p3.Value.ToString() ;
           TextBox4.Text = p4.Value.ToString() ;
           TextBox5.Text = p5.Value.ToString() ;

            con.Close();

Modify the SP

create PROCEDURE [dbo].[profdata]
	@username nvarchar (50) OUTPUT, 
	@password nvarchar (50) output,
	@firstname NVARCHAR(50) output,
    @lastname NVARCHAR(50) output,
    @email NVARCHAR(50) OUTPUT
AS
BEGIN
	
	SET NOCOUNT ON;
 
SET @lastname = (SELECT [Last Name] FROM PROFILE WHERE @username=Username)
SET @firstname = (SELECT [First Name] FROM PROFILE WHERE @username=Username)
SET @email = (SELECT [E-Mail] FROM PROFILE WHERE @username=Username)
 
END

Toniyo Jackson · Answer 2 · 2011-08-03T21:26:00

Solution 2

You have to understand the basic. Please go through the below link.

http://www.csharpfriends.com/articles/getarticle.aspx?articleid=78[^]

Posted 3-Aug-11 21:26pm

Toniyo Jackson

SanjeevSingh · Answer 3 · 2011-08-03T21:12:00

Solution 1

Hello Prashant,

Please follow the link. take a study on store porcedure and Ado.net. it will help you.
Click Here[^]

thanks
sanjeev

Posted 3-Aug-11 21:12pm

SanjeevSingh