Incorrect syntax near '=' SQL

Question

0.00/5 (No votes)

See more:

Hi,
I keep getting the error "Incorrect syntax near '='"
Below is my code.
I can't find fault in it could someone please take a look.

Thanks.

private void Information_Load(object sender, EventArgs e)
        {
            string dbs = "Data Source=OMEGA;Initial Catalog=Military;Integrated Security=true;";
            string sql = "SELECT * From Personal WHERE UserId = " + comboBox1.Text;
            using (SqlConnection connection = new SqlConnection(dbs))
            {
                SqlDataAdapter da = new SqlDataAdapter(new SqlCommand(sql, connection));
                DataSet ds = new DataSet("Image");
                ds.Tables.Add("Image");
                da.Fill(ds.Tables["Image"]);
                listBox1.DataSource = ds.Tables["Image"];
                listBox1.DisplayMember = "UserID";
            }

        }

Posted 19-May-11 8:03am

WurmInfinity

Add a Solution

Comments

CPallini 19-May-11 14:16pm

Wow, you're posting here top secret military code?
:-D

yesotaso 19-May-11 14:59pm

Not only military... look at data source!!

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Andrew Rissing · Accepted Answer · 2011-05-19T08:12:00

Your problem is because you are not using quotes around your UserId.

So, change the following line:

string sql = "SELECT * From Personal WHERE UserId = " + comboBox1.Text;

To:

string sql = "SELECT * From Personal WHERE UserId = '" + comboBox1.Text + "'";

Assuming you have complete control over the values that are placed into the combobox.

Personally, I would use SqlParameters for this, as it would help prevent SQL injection issues.