Favorites to ToolBar, Navigation and Store Problem

Question

0.00/5 (No votes)

See more:

I'm trying to make a toolbar that holds favorite buttons. The buttons hold the browser.Url.ToString(); and the browser.DocumentTitle.ToString();

I have this code:

private void button1_Click_1(object sender, RoutedEventArgs e)
        {
            System.Windows.Forms.WebBrowser browser = GetCurrentWebBrowser();
            //ButtonBar.Items.Add(newItem: browser.DocumentTitle.ToString());
            groupBox1.Visibility = Visibility.Hidden;
            var tb = new System.Windows.Controls.ToolBar();

            tb = ButtonBar;

            var b = new System.Windows.Controls.Button();
            var l = new System.Windows.Forms.Label();

            l.Text = browser.Url.ToString();

            b.CommandParameter = browser.Url.ToString();
            b.Content = textBox2.Text;
            tb.Items.Add(b);
            b.Click += new RoutedEventHandler(b_Click);
            b.Tag = browser.Url.ToString();

        }

        void b_Click(object sender, RoutedEventArgs e)
        {
                var l = new System.Windows.Forms.Label();
                var b = new System.Windows.Controls.Button();

                ButtonBar.Items.ToString();
                System.Windows.Forms.WebBrowser browser = GetCurrentWebBrowser();

ERROR HERE >>>>>>>>>>> browser.Navigate(b.Tag.ToString());
            
      }

You can see that i have some failed attempts to make the Buttons to hold the browser's Url..

Any suggestion how to make the buttons i create to hold both the browser.Url from the textBox and the browser.DocumentText as Content?

If im not clear enough just tell me ;)

EDIT: When i run this code i get "Object reference not set to an instance of an object." the problem is at the Navigation point with the b.Tag.ToString();

Posted 22-Feb-11 0:57am

Hej då

Updated 22-Feb-11 4:29am

v4

Add a Solution

Comments

Sandeep Mewara 22-Feb-11 9:18am

If you use VS Debugger, it would just take a minute to find where exactly that error happens.

You must be using some property of an object that is null.

Hej då 22-Feb-11 9:29am

Do you have any idea of an object that can hold this strings for the buttons that this code create? u can see that i bolded where the error occurs :)

Henry Minute 22-Feb-11 10:18am

Unfortunately bolding doesn't show up very well in code snippets.

Better to add a comment at the end of the problem statement, like:
browser.Navigate(b.Tag.ToString()); // <++++++++++++++++++++ error here +++++++++++++++
or similar. :)

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Henry Minute · Accepted Answer · 2011-02-22T04:26:00

There are several problems in your code but the error you are reporting is caused by the fact that you create a new button and then try to use it's Tag property which is null. (a new button doesn't have anything assigned to it's tag).

C#

void b_Click(object sender, RoutedEventArgs e)
{
        var l = new System.Windows.Forms.Label();
        var b = new System.Windows.Controls.Button(); // <====== b = a new button here (empty Tag)
        ButtonBar.Items.ToString();
        System.Windows.Forms.WebBrowser browser = GetCurrentWebBrowser();
        browser.Navigate(b.Tag.ToString()); // <======= Try to use Tag here and it's null
}

you probably want something like

C#

Button b = sender as System.Windows.Controls.Button;
if (b != null)
{
    // rest of your code here
}