not able to bind gridview

Question

5.00/5 (1 vote)

See more:

In this code I'm not able to bind gridview.
When record is saving to database, it is saving two times.

Please check my code and correct it.
I cannot find the problem.

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.SqlClient;
using System.Data;
namespace Insurance
{
    public partial class Create_New_Customer : System.Web.UI.Page
    {
        DataSet ds = new DataSet();
        SqlConnection con;
        SqlCommand cmd = new SqlCommand();
        SqlParameter sp1 = new SqlParameter();
        SqlParameter sp2 = new SqlParameter();
        SqlParameter sp3 = new SqlParameter();
        SqlParameter sp4 = new SqlParameter();
        SqlParameter sp5 = new SqlParameter();
        SqlParameter sp6 = new SqlParameter();
        SqlParameter sp7 = new SqlParameter();
      
        protected void Page_Load(object sender, EventArgs e)
        {
         }
        protected void btnSave_Click1(object sender, EventArgs e)
        { con = new SqlConnection("Data Source=NSEZ-DD4-028;Initial Catalog=Insurance;Integrated Security= SSPI");
         
            cmd = new SqlCommand("Create_Customer", con);
            cmd.CommandType = CommandType.StoredProcedure;
            con.Open();
            cmd.Connection = con;
            cmd.Parameters.Add("@First_Name", SqlDbType.VarChar).Value = txtFirstName.Text.ToString();
            cmd.Parameters.Add("@Last_Name", SqlDbType.VarChar).Value = txtLastName.Text.ToString();
            cmd.Parameters.Add("@Address1", SqlDbType.VarChar).Value = txtAddress.Text.ToString();
            cmd.Parameters.Add("@City", SqlDbType.VarChar).Value = txtCity.Text.ToString();
            cmd.Parameters.Add("@State", SqlDbType.VarChar).Value = txtState.Text.ToString();
            cmd.Parameters.Add("@Zip", SqlDbType.Int).Value = txtZip.Text;
            cmd.Parameters.Add("@Country", SqlDbType.VarChar).Value = txtCountry.Text.ToString();
            SqlDataReader MyDataReader = cmd.ExecuteReader();
          
            MyDataReader.Close();
            cmd.ExecuteNonQuery();
            con.Close();


            con = new SqlConnection("Data Source=NSEZ-DD4-028;Initial Catalog=Insurance;Integrated Security= SSPI");
         
            cmd = new SqlCommand("Create_Customer_All", con);
            cmd.CommandType = CommandType.StoredProcedure;
            con.Open();
            cmd.Connection = con;
            SqlDataAdapter adapter = new SqlDataAdapter(cmd);
            adapter.Fill(ds);
            gridviewCustomer.DataSource = ds;
            gridviewCustomer.DataBind();
            con.Close();
      }

        protected void btnCancel_Click(object sender, EventArgs e)
        {
            txtFirstName.Text = "";
            txtLastName.Text = "";
            txtAddress.Text = "";
            txtCity.Text = "";
            txtState.Text = "";
            txtZip.Text = "";
            txtCountry.Text = "";
        }
        protected void btnMainWindow_Click(object sender, EventArgs e)
        {
            Response.Redirect("Main.aspx");
       }
        protected void txtCity_TextChanged(object sender, EventArgs e)
        {
        }
}
}

Posted 29-Nov-10 18:49pm

goelhima

Updated 29-Nov-10 21:54pm

Dalek Dave

v3

Add a Solution

Comments

Sunasara Imdadhusen 30-Nov-10 0:54am

Please check value for ds (adapter.Fill(ds);) will filled dataset with value?

goelhima 30-Nov-10 1:16am

in dataset records saved in table is showing...but not binding with gridview?

Dalek Dave 30-Nov-10 3:54am

Edited for Grammar and Syntax.

4 solutions

Solution 1

Change the following line:

C#

gridviewCustomer.DataSource = ds;
           gridviewCustomer.DataBind();

to

C#

gridviewCustomer.DataSource = ds.Tables[0];
// OR
// gridviewCustomer.DataSource = ds.Tables["myTable"];
           gridviewCustomer.DataBind();

Posted 29-Nov-10 20:50pm

Sandeep Mewara

Comments

Dalek Dave 30-Nov-10 3:54am

Oh well spotted.

Solution 4

thanq u soo much for ur help :)

its done....i firstly removed reader , than opened new connection for gridview :)

Posted 29-Nov-10 23:10pm

goelhima

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sudheer Kumar K · Accepted Answer · 2010-11-29T22:00:00

Solution 2

Hi,

you don't need the SQLDataReader when you want to execute the executenonquery

Remove the following lines of code also.
SqlDataReader MyDataReader = cmd.ExecuteReader();

MyDataReader.Close();

Posted 29-Nov-10 22:00pm

Sudheer Kumar K

Mohd Wasif · Accepted Answer · 2010-11-29T22:44:00

/*Use Like It Hope your Problem will be sort out */

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.SqlClient;
using System.Data;
namespace Insurance
{
public partial class Create_New_Customer : System.Web.UI.Page
{
DataSet ds = new DataSet();
SqlConnection con;
SqlCommand cmd = new SqlCommand();
SqlParameter sp1 = new SqlParameter();
SqlParameter sp2 = new SqlParameter();
SqlParameter sp3 = new SqlParameter();
SqlParameter sp4 = new SqlParameter();
SqlParameter sp5 = new SqlParameter();
SqlParameter sp6 = new SqlParameter();
SqlParameter sp7 = new SqlParameter();

protected void Page_Load(object sender, EventArgs e)
{

if(!IsPostBack)
{
BindGridView();
}

}
protected void btnSave_Click1(object sender, EventArgs e)
{
con = new SqlConnection("Data Source=NSEZ-DD4-028;

Initial Catalog=Insurance;Integrated Security= SSPI");

cmd = new SqlCommand("Create_Customer", con);
cmd.CommandType = CommandType.StoredProcedure;
con.Open();
cmd.Connection = con;
cmd.Parameters.Add("@First_Name", SqlDbType.VarChar).Value = txtFirstName.Text.ToString();
cmd.Parameters.Add("@Last_Name", SqlDbType.VarChar).Value = txtLastName.Text.ToString();
cmd.Parameters.Add("@Address1", SqlDbType.VarChar).Value = txtAddress.Text.ToString();
cmd.Parameters.Add("@City", SqlDbType.VarChar).Value = txtCity.Text.ToString();
cmd.Parameters.Add("@State", SqlDbType.VarChar).Value = txtState.Text.ToString();
cmd.Parameters.Add("@Zip", SqlDbType.Int).Value = txtZip.Text;
cmd.Parameters.Add("@Country", SqlDbType.VarChar).Value = txtCountry.Text.ToString();
con.Open();
cmd.ExecuteNonQuery();
con.Close();
Clear();
BindGridView();

}
Void BindGridView()
{
con = new SqlConnection("Data Source=NSEZ-DD4-028;Initial Catalog=Insurance;Integrated Security= SSPI");

cmd = new SqlCommand("Create_Customer_All", con);
cmd.CommandType = CommandType.StoredProcedure;
con.Open();
cmd.Connection = con;
SqlDataAdapter adapter = new SqlDataAdapter(cmd);
adapter.Fill(ds);
gridviewCustomer.DataSource = ds;
gridviewCustomer.DataBind();
con.Close();
}

protected void btnCancel_Click(object sender, EventArgs e)
{
Clear();
}
Void Clear()
{

MIDL

txtFirstName.Text = "";
         txtLastName.Text = "";
         txtAddress.Text = "";
         txtCity.Text = "";
         txtState.Text = "";
         txtZip.Text = "";
         txtCountry.Text = "";

}
protected void btnMainWindow_Click(object sender, EventArgs e)
{
Response.Redirect("Main.aspx");
}
protected void txtCity_TextChanged(object sender, EventArgs e)
{
}
}
}