'Cannot deserialize the current JSON object (e.g. {"Name":"value"}) into type 'system.collections.generic.list`1...

Question

0.00/5 (No votes)

See more:

Hello, I get such JSON and want to deserialize it into my C# object.

JSON (partially):

{
    "Quotes": [
        {
            "QuoteId": 1,
            "MinPrice": 119,
            "Direct": true,
            "OutboundLeg": {
                "CarrierIds": [
                    851
                ],
                "OriginId": 81727,
                "DestinationId": 60987,
                "DepartureDate": "2019-04-01T00:00:00"
            },
            "QuoteDateTime": "2019-03-10T19:27:00"
        }
    ],
    "Places": [
        {
            "PlaceId": 60987,
            "IataCode": "JFK",
            "Name": "New York John F. Kennedy",
            "Type": "Station",
            "SkyscannerCode": "JFK",
            "CityName": "New York",
            "CityId": "NYCA",
            "CountryName": "United States"
        },
        {
            "PlaceId": 81727,
            "IataCode": "SFO",
            "Name": "San Francisco International",
            "Type": "Station",
            "SkyscannerCode": "SFO",
            "CityName": "San Francisco",
            "CityId": "SFOA",
            "CountryName": "United States"
        }
    ]   
}

My classes:

public class MyQuotes

    {
        public List<Quote> Quotes { get; set; }
        public List<Place> Places { get; set; }
    }

    public class Quote
    {
        public int QuoteId { get; set; }
        public List<MyOutboundLeg> OutboundLeg { get; set; }
    }

    public class MyOutboundLeg
    {
        public List<int> CarrierIds { get; set; }
        public int OriginId { get; set; }
    }

    public class Place
    { 
        public string PlaceId { get; set; }
        public string CountryName { get; set; }
    }
    
    }

What I have tried:

var body = ApiTestContext.Response.Content.ReadAsStringAsync().Result;
            MyQuotes myQuotes = JsonConvert.DeserializeObject<MyQuotes>(body);

Posted 11-Mar-19 2:57am

Member 14178219

Updated 11-Mar-19 3:46am

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

#realJSOP · Accepted Answer · 2019-03-11T03:35:00

Solution 1

Don't all of the fields in the json have to be present in the class, AND don't they all have to be named the same in the JSON and the class? How else is it going to be able to serialize?

You're missing fields in your class definition, and one of the fields isn't named the same as what's in the json data (this is where the exception is happening - JSON has "Name", and your class has "PlaceName").

Posted 11-Mar-19 3:35am

#realJSOP

Updated 11-Mar-19 3:37am

v4

Comments

Member 14178219 11-Mar-19 9:45am

Thank you, I have renamed the field "PlaceName", but as I know not all of the fields from JSON have to be present in the class, only fields which I want to use later. And I still get the same error

OriginalGriff · Accepted Answer · 2019-03-11T03:38:00

That's because your JSON doesn't match your class definitions.
Try an online generator (here's the one I use: json2csharp - generate c# classes from json[^] ) and you get this:

public class OutboundLeg
{
    public List<int> CarrierIds { get; set; }
    public int OriginId { get; set; }
    public int DestinationId { get; set; }
    public DateTime DepartureDate { get; set; }
}

public class Quote
{
    public int QuoteId { get; set; }
    public int MinPrice { get; set; }
    public bool Direct { get; set; }
    public OutboundLeg OutboundLeg { get; set; }
    public DateTime QuoteDateTime { get; set; }
}

public class Place
{
    public int PlaceId { get; set; }
    public string IataCode { get; set; }
    public string Name { get; set; }
    public string Type { get; set; }
    public string SkyscannerCode { get; set; }
    public string CityName { get; set; }
    public string CityId { get; set; }
    public string CountryName { get; set; }
}

public class RootObject
{
    public List<Quote> Quotes { get; set; }
    public List<Place> Places { get; set; }
}

Wastedtalent · Accepted Answer · 2019-03-11T03:43:00

Your Outbound Leg class is a property in your JSON but a List in your Quote class:

public class Quote
    {
        public int QuoteId { get; set; }
        public List<MyOutboundLeg> OutboundLeg { get; set; }
    }

Should be:

public class Quote
    {		
        public int QuoteId { get; set; }
        public MyOutboundLeg OutboundLeg { get; set; }
    }

'Cannot deserialize the current JSON object (e.g. {"Name":"value"}) into type 'system.collections.generic.list`1...

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0