I am writing program to count number occurance

Question

1.00/5 (1 vote)

See more:

C

#include<stdio.h>
#include<conio.h>

int a,i,b,num;
int main()
{

scanf("%d",&a);

	for(i=0;i<10;i++)
{
	
	while(a!=0)
	{
		num=(a%10);
		if(num==i)
		{
			b++;
		}
		a=a/10;
	
	}

	printf(" %d number  %d  times\n",i,b);

}
	
	return 0;
}

What I have tried:

yes but not working can u please help to figure out whats wrong in it

Posted 11-Jan-18 7:46am

Member 13618624

Updated 11-Jan-18 10:33am

CPallini

v2

Add a Solution

Comments

jeron1 11-Jan-18 13:59pm

The first time you exit the while loop the value of a is zero. Then next time you hit the while statement a is still zero.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2018-01-11T10:33:00

Learn to indent properly your code, it show its structure and it helps reading and understanding. It also helps spotting structures mistakes.

C++

#include<stdio.h>
#include<conio.h>

int a,i,b,num;
int main()
{
  scanf("%d",&a);

  for(i=0;i<10;i++)
  {

    while(a!=0)
    {
      num=(a%10);
      if(num==i)
      {
        b++;
      }
      a=a/10;
    }
    printf(" %d number  %d  times\n",i,b);
  }
  return 0;
}

Professional programmer's editors have this feature and others ones such as parenthesis matching and syntax highlighting.
Notepad++ Home[^]
ultraedit[^]
-----
You algorithm is not efficient, it is doing 10 times the work.
It is more efficient to use an array and count digits as they appears.
-----
Advice: Learn to use the debugger, it is a great learning tool that help you to find bugs.

There is a tool that allow you to see what your code is doing, its name is debugger. It is also a great learning tool because it show you reality and you can see which expectation match reality.
When you don't understand what your code is doing or why it does what it does, the answer is debugger.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.

Thomas Daniels · Answer 2 · 2018-01-11T08:03:00

Two problems:

'a' gets divided down to zero but the value never gets reset.
'b' never gets reset to zero.

To fix these problems, you can create an extra variable c that you'll use to perform the divison by 10 and copy a to it at the start of the loop, and to set b to zero at the start of the loop, like this:

C

int a, i, b, c, num;
int main()
{

	scanf("%d", &a);

	for (i = 0; i < 10; i++)
	{
		b = 0;
		c = a;
		while (c != 0)
		{
			num = (c % 10);
			if (num == i)
			{
				b++;
			}
			c = c / 10;
		}
		printf(" %d number  %d  times\n", i, b);
	}
	return 0;
}

Note that you'll see unexpected results if the input is larger than the max value of an integer: the integer will overflow[^] and the value wouldn't be what you inputted. If you want to do this for a number with unlimited digits, you'll have to store the value in a string instead and perform comparisons on the characters of the string.

CPallini · Answer 3 · 2018-01-11T08:19:00

You should the occurrence of every digit starting with the same value of a, that is, you need to backup it. Try

C

#include <stdio.h>

int main()
{

  int a, i;
  scanf("%d",&a);

  for(i=0;i<10;i++)
  {
    int tmp = a;
    int cnt = 0;
    int dgt;

    while(tmp != 0)
    {
      dgt = (tmp % 10);
      if ( dgt == i)
      {
        cnt++;
      }
      tmp = tmp / 10;
    }

    printf(" %d digit  %d  times\n", i, cnt);

  }

  return 0;
}

I am writing program to count number occurance

3 solutions

Solution 3

Solution 1

Solution 2

Add your solution here

Preview 0