How to refactor in linq..?

Question

0.00/5 (No votes)

See more:

C#

public List<carlistviewmodel> GetFilter(List<string> HondaCustomer, List<carlistviewmodel> CarList)
        {
            List<carlistviewmodel> List = new List<carlistviewmodel>();
            
                foreach (string Hcustomer in HondaCustomer)
                {
                    foreach (CarListViewModel detail in CarList)
                    {
                        if (detail.CustomerName == Hcustomer)
                        {
                            List.Add(detail);

                        }
                    }
                }
            

            return List;
        }

What I have tried:

C#

public List<carlistviewmodel> GetFilter(List<string> HondaCustomer, List<carlistviewmodel> CarList)
        {
            List<carlistviewmodel> List = new List<carlistviewmodel>();
            
                foreach (string Hcustomer in HondaCustomer)
                {
                    foreach (CarListViewModel detail in CarList)
                    {
                        if (detail.CustomerName == Hcustomer)
                        {
                            List.Add(detail);

                        }
                    }
                }
            

            return List;
        }

Posted 17-Nov-17 7:56am

Salt Pepper

Updated 17-Nov-17 20:09pm

Kenneth Haugland

v2

Add a Solution

Comments

BillWoodruff 17-Nov-17 18:07pm

What happens now when you run your code: what errors; what unexpected result ? Your learning to analyze your code, to set breakpoints, etc., is critical for you to progress as a programmer.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

J. Calhoun · Accepted Answer · 2017-11-17T09:04:00

Solution 1

If I understand the question correctly I think you are looking for:

List<carlistviewmodel> List = CarList.Where(detail => HondaCustomer.Contains(detail.CustomerName)).toList();

Posted 17-Nov-17 9:04am

J. Calhoun

Comments

BillWoodruff 17-Nov-17 18:04pm

+5 solid solution