Which is the best code VB.NET

Question

1.67/5 (2 votes)

See more:

VB

If role = "Administrator" Then
   MultiLevelMenu.Visible = True
Else
   MultiLevelMenu.Visible = False
End If

or

VB

MultiLevelMenu.Visible = role = "Administrator"

What I have tried:

Is it just readability?

Posted 30-Jan-17 21:39pm

Member 10103170

Updated 30-Jan-17 22:48pm

Suvendu Shekhar Giri

v3

Add a Solution

3 solutions

Solution 1

Use the first: the second is confusing to read as it implies that it should read as two assignments:

VB

role = "Administrator"
MultiLevelMenu.Visible = role

(This is one of the reasons C# is a better language than VB: the assignment operator "=" is not the same as the equality test operator "==")

If you feel you must write the second form, then at least use brackets to make it clearer:

VB

MultiLevelMenu.Visible = (role = "Administrator")

But just because you can do something, doesn't mean you should...

Posted 30-Jan-17 22:37pm

OriginalGriff

Solution 2

I am not from VB.Net background but if I can relate this to C#, either you can try the first one i.e,

VB

If role = "Administrator" Then
   MultiLevelMenu.Visible = True
Else
   MultiLevelMenu.Visible = False
End If

Or you can use Ternary Operator

VB

'MultiLevelMenu.Visible = (role == "Administrator"? true : false) //in c#
MultiLevelMenu.Visible = If(role = "Administrator", true, false)

From performance point of view both should be same as these statements will be translated to MSIL and should same at that time.

Hope, it helps :)

Posted 30-Jan-17 22:44pm

Suvendu Shekhar Giri

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Accepted Answer · 2017-01-30T22:48:00

Solution 3

Both codes are doing the same and they compiled to same code too.
First form is usually preferred by beginners because they find it easier to read.
Second form is usually preferred by experimented users because it is more compact and as easy to read.
I prefer

VB

MultiLevelMenu.Visible = ( role = "Administrator" )

because some language allow cascade assignment and seconf form translate to:

VB

role = "Administrator"
MultiLevelMenu.Visible = role

Posted 30-Jan-17 22:48pm

Patrice T

Comments

Member 10103170 31-Jan-17 10:09am

Thanks, was not sure if it was more efficient, but if it compiles to same code then a more easy to read segment will be fine.

Patrice T 31-Jan-17 11:32am

Modern compilers are optimizers.