How to get a data from datatable to list

Question

4.00/5 (1 vote)

See more:

C#

public class Location_Master
    {
                
        public List<Locations> Locations { get; set; }
        public List<Response> Response { get; set; }
    }

    public class Locations
    {
        public int id { get; set; }
        public string lat { get; set; }
        public string longs { get; set; }
        public string country { get; set; }
        public string country_code { get; set; }
        public string name { get; set; }
        public int country_id { get; set; }
    }

C#

public void Locations(Location_Master lm)
        {
            DataTable _dt = new DataTable();
            _balL = new Safety_DAL.BALLocation();
                _dt = _balL.getAllLocations();
                lm.Locations = (from DataRow dr in _dt.Rows
                                select new Locations()
                                {
                                    id = Convert.ToInt32(_dt.Rows[0]["id"].ToString()),
                                    country = _dt.Rows[0]["country_name"].ToString(),
                                    country_code = _dt.Rows[0]["Country_ISD_Code"].ToString(),
                                    lat = _dt.Rows[0]["Location_Lat"].ToString(),
                                    longs = _dt.Rows[0]["Location_Long"].ToString(),
                                    name = _dt.Rows[0]["Name"].ToString(),
                                    country_id = Convert.ToInt32(_dt.Rows[0]["country_id"].ToString())
                                }).ToList();
                
                lm.Response = new List<Response>(){
                    new Response(){
                        response_code = 1,
                        success = true
                    }
                };
            }

output

"Locations": [
{
"id": 1,
"lat": "19.0760° N",
"longs": "72.8777° E",
"country": "India",
"country_code": "91",
"name": "Mumbai",
"country_id": 92
},
{
"id": 1,
"lat": "19.0760° N",
"longs": "72.8777° E",
"country": "India",
"country_code": "91",
"name": "Mumbai",
"country_id": 92
}
]

What I have tried:

i am getting the same record in in the list as above output, same id and other data too where as it's should be id 1 and id 2

C#

public class Location_Master
    {
        //public Int32 id { get; set; }
        //public string name { get; set; }

        //public virtual ICollection<Incident_Data> Incident_Data { get; set; }
        //public virtual User_Master User_Master { get; set; }
        public List<Locations> Locations { get; set; }
        public List<Response> Response { get; set; }
    }

    public class Locations
    {
        public int id { get; set; }
        public string lat { get; set; }
        public string longs { get; set; }
        public string country { get; set; }
        public string country_code { get; set; }
        public string name { get; set; }
        public int country_id { get; set; }
    }

C#

public void Locations(Location_Master lm)
        {
            DataTable _dt = new DataTable();
            _balL = new Safety_DAL.BALLocation();
                _dt = _balL.getAllLocations();
                lm.Locations = (from DataRow dr in _dt.Rows
                                select new Locations()
                                {
                                    id = Convert.ToInt32(_dt.Rows[0]["id"].ToString()),
                                    country = _dt.Rows[0]["country_name"].ToString(),
                                    country_code = _dt.Rows[0]["Country_ISD_Code"].ToString(),
                                    lat = _dt.Rows[0]["Location_Lat"].ToString(),
                                    longs = _dt.Rows[0]["Location_Long"].ToString(),
                                    name = _dt.Rows[0]["Name"].ToString(),
                                    country_id = Convert.ToInt32(_dt.Rows[0]["country_id"].ToString())
                                }).ToList();
                
                lm.Response = new List<Response>(){
                    new Response(){
                        response_code = 1,
                        success = true
                    }
                };
            }

Posted 5-Oct-16 4:45am

nik varma

Updated 5-Oct-16 5:12am

Add a Solution

2 solutions

Solution 2

C#

List<Locations> locations = new List<Locations>();

DataTableReader reader = dt.CreateDataReader();
if (reader != null && reader.HasRows)
{
    while (reader.Read())
    {
        locations.Add(new Locations()
        {
            // call the appropriate reader.GetXXXXX mthod that is appropriate for the property type
            id = reader.GetInt32("id"),
            ...
        });
    }
}

I wrote a bunch of extension methods for the DataTableReader that allows me to assign default values in case something came back wonky (yes, my data environment may produce wonky results, even from the database). I also access the reader by the column's ordinal value instead of by name so I can verify that the desired column actually exists in the table. An example:

C#

public static Int32 GetInt32OrDefault(this DataTableReader reader, int ordinal, Int32 defaultValue)
{
    Int32 value = defaultValue;
    if (!reader.IsDBNull(ordinal))
    {
        value = reader.GetInt32(ordinal);
    }
    return value;
}

Posted 5-Oct-16 5:12am

#realJSOP

Updated 5-Oct-16 5:20am

v3

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Andy Lanng · Accepted Answer · 2016-10-05T05:00:00

Solution 1

You're going to kick yourself when you see it :P

change

C#

id = Convert.ToInt32(_dt.Rows[0]["id"].ToString())

to

C#

id = Convert.ToInt32(dr["id"].ToString())

do that for each item in the linq query

Posted 5-Oct-16 5:00am

Andy Lanng

Comments

nik varma 5-Oct-16 11:12am

haha, yes
just found a link, but thank you so much and have given you a full rating :)
http://www.aspdotnet-suresh.com/2014/11/csharp-convert-datatable-to-generic-list-example-using-linq.html