Why is my javascript not working?

Question

0.00/5 (No votes)

See more:

Hi. I'm totally beginner in javascript. I made a form with a button but the external javascript is not working.

HTML

<head>
    <title>...</title>
    <script type="text/javascript" src="/media/js/script.js"></script>
</head>
<body>
      <form name="infoForm1" id="mainInfoForm">
             ...
             <input type="button" name="btnSaveMainInfo" value="ABC" onClick="validateAndCreate()" />
      </form>
</body>

What I have tried:

This is external javascript I'm using:

JavaScript

function validateAndCreate(){
     alert("aaabbbccc");
}

Posted 18-Apr-16 20:27pm

PeMaCN

Updated 18-Apr-16 21:43pm

v2

Add a Solution

Comments

Passion4Code 19-Apr-16 2:33am

When will this function be called? You have no link to the function in the HTML elements.

F-ES Sitecore 19-Apr-16 4:29am

You should learn to use the browser tools to debug these issues (F12 on IE or Chrome). First check the network tab to ensure the js file is found (ie that it doesn't have a status of 404), then check the console for errors.

2 solutions

Solution 1

Hello ,

Try adding the below:

HTML

<input type="button" name="btnSaveMainInfo" onclick="validateAndCreate()" value="ABC" />
   </form>

Edit fiddle - JSFiddle[^]

You need to have an onclick event attached to the input DOM for the function to be called.

Thanks

Posted 18-Apr-16 20:38pm

Passion4Code

Updated 18-Apr-16 20:52pm

v4

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Peter Leow · Accepted Answer · 2016-04-18T21:43:00

Solution 2

Add a dot to indicate that the relative path starts from current directory, i.e.

src="./media/js/script.js"

btw, a path starting with

is relative to site root.
Learn more: definition: linking, absolute, relative, root, path, hyperlinks | Motive Web Design Glossary[^]

Posted 18-Apr-16 21:43pm

Peter Leow

Updated 18-Apr-16 21:50pm

v3

Comments

Karthik_Mahalingam 19-Apr-16 4:48am

5 for Learn more :)

Peter Leow 19-Apr-16 4:49am

Thank you, Karthik.

PeMaCN 19-Apr-16 5:01am

No,this is not working

Peter Leow 19-Apr-16 5:03am

What is not working, be more specific. Where did you place the external js file?

PeMaCN 19-Apr-16 5:36am

Sorry, it's working. I had one bracket which was causing javascript not working

Peter Leow 19-Apr-16 6:00am

It's okay. All's well that ends well.