Facing error of mysql query not proper check in manual

Question

1.00/5 (1 vote)

See more:

VS2015

I am trying to fire this query through c# code to mysql server database but following error is occurred. Is my query wrong. plz help. I am using mysql server 5.0

string chkUser = "Select * FROM [User] where Email='"+ UserName + "'AND Password='" + Password + "';";

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near

What I have tried:

I am trying to fire this query through c# code to mysql server database but following error is occurred. Is my query wrong. plz help. I am using mysql server 5.0

string chkUser = "Select * FROM [User] where Email='"+ UserName + "'AND Password='" + Password + "';";

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near

Posted 23-Mar-16 10:03am

Kishor-KW

Updated 23-Mar-16 10:34am

Add a Solution

Comments

Richard Deeming 23-Mar-16 16:13pm

Your code is vulnerable to SQL Injection[^]. NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

Also, you're storing passwords in plain text. That is an extremely bad idea. You should only ever store a salted hash of the password, using a unique salt per record.

Secure Password Authentication Explained Simply[^]
Salted Password Hashing - Doing it Right[^]

Kishor-KW 23-Mar-16 16:29pm

yes I know about mysql injection but here i did not take care of it. please give me solution on same query

CHill60 23-Mar-16 16:29pm

What was the word or character after "near"? That would be the bit of the error message that tells you where the problem is!

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CHill60 · Answer 1 · 2016-03-23T10:34:00

Solution 1

Your query should be

C#

string chkUser = "Select * FROM [User] where Email=@UserName AND Password=@Password;";

Use command parameters to provide the values for @UserName and @Password You've said you know about this so I haven't provided an example.

Note the space before AND

Posted 23-Mar-16 10:34am

CHill60

Comments

Kishor-KW 24-Mar-16 15:30pm

Means we can't use this syntax in mysql. as we can in mssql

CHill60 26-Mar-16 14:17pm

The MySQL classes for .NET also take command parameters so you can use this for MySQL. See MySQL :: MySQL Connector/Net Developer Guide :: 5.1.4 Working with Parameters[^]