small and bigger number in c#

Question

1.00/5 (3 votes)

See more:

HI
i want to create a program in c# who take 5 numbers and show which number is smaller and which one is greater?

i try this

C#

 static void Main()
        {
//        
             int n1, n2, n3,n4,n5;
            Console.WriteLine("Enter Three no:");
            n1=Convert.ToInt32(Console.ReadLine());
            n2=Convert.ToInt32(Console.ReadLine());
            n3=Convert.ToInt32(Console.ReadLine());
            n4=Convert.ToInt32(Console.ReadLine());
            n4=Convert.ToInt32(Console.ReadLine());
           
                   if(n1>n5)
                 {
                     Console.WriteLine("The Greatest Of Three numbers are:"+n1);
                     Console.ReadLine();
                  }
                  if (n1<n5)
                 { 
                     Console.WriteLine("The samllestt Of Three numbers are:"+n5);
                     Console.ReadLine();
                  }
                  
          }

but this can not show me smallest number only show greater number and i want both samllest and largest number

any one tell me

Posted 11-Jul-15 1:10am

Diya Ayesa

Add a Solution

Comments

[no name] 11-Jul-15 7:19am

That is because, mainly, you are only checking one of the numbers against one of the other numbers. You need to check ALL of the numbers against each other.

2 solutions

Solution 2

You can use the Math.Max and Math.Min methods to avoid building and sorting an array

C#

int max = 0;
int min = 0;
for (int i = 0; i < 5; i++)
{
     Console.Write("Enter number: ");
    int res = Convert.ToInt32(Console.ReadLine());
    if (i == 0)
    {
        min = max = res;
    }
    else
    {
        max = Math.Max(max, res);
        min = Math.Min(min, res);
    }
}
Console.WriteLine("Largest  : {0}\tSmallest : {1}", max, min);

Posted 11-Jul-15 12:26pm

George Swan

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-07-11T01:24:00

The easiest - and most flexible way - is to read them into an array, sort the array, and then you have the maximum and minimum immediately:

C#

int[] data = new int[5];
for (int i = 0; i < data.Length; i++)
   {
   string inp = "";
   while (!int.TryParse(inp, out data[i]))
      {
      Console.Write("Enter number {0}: ", i + 1);
      inp = Console.ReadLine();
      }
   }
Array.Sort(data);
Console.WriteLine("Largest  : {0}\nSmallest : {1}", data[data.Length - 1], data[0]);

"yes i know about Conditional ("if") statements? Sorting? Console.WriteLine? but loops and arrays little bit"

Ok: so let's make a version that works with five numbers and doesn't use an array or loop (or check the user input, just to make it easier to read):

C#

int max, min;
Console.WriteLine("Enter five numbers:");
int val = Convert.ToInt32(Console.ReadLine());
max = val;
min = val;
val = Convert.ToInt32(Console.ReadLine());
if (val > max) max = val;
if (val < min) min = val;
val = Convert.ToInt32(Console.ReadLine());
if (val > max) max = val;
if (val < min) min = val;
val = Convert.ToInt32(Console.ReadLine());
if (val > max) max = val;
if (val < min) min = val;
val = Convert.ToInt32(Console.ReadLine());
if (val > max) max = val;
if (val < min) min = val;

Console.WriteLine("The Greatest number is {0}", max);
Console.WriteLine("The Smallest number is {0}", min);

We start by setting up - assign variables to hold the largest and smallest numbers.
Then, set them to the first user input - because that will be the largest and smallest value if there is only one input.
Then for each of the others, check against the current value and replace f we have a new largest or smallest.
Finally, print the result.

This isn't "good code" - it has a lot of problems:
1) It doesn't check the user entered a number. If he doesn't, then the application crashes. And boy! Do people even make mistakes! If we don't handle them well, we end up annoying the user and he stops using our application (or in extreme cases comes round to your desk and hits you). Think about it: if you have just entered 4 numbers out of 5 and you hit "]" when you press enter it's not a major problem if the app crashes. Annoying, yes. But the user will sigh, roll his eyes to the ceiling and do it again. But if it's the 99th number of a hundred? He's going to be very annoyed...
That's why my example had this code:

C#

while (!int.TryParse(inp, out data[i]))
   {
   Console.Write("Enter number {0}: ", i + 1);
   inp = Console.ReadLine();
   }

It checks if the user made a mistake, and prompts him to re-enter until he gets it right without the app crashing when he does.
2) It's a pain to expand: today you want five numbers, but if tomorrow you need to do the same for 100 you have a lot of code to copy and paste! A loop makes it a lot simpler - which makes it more reliable - but you'll find out about them later, I'm sure.

Make a bit more sense to you?