How to insert mulitple datas using stored procedure

Question

1.00/5 (1 vote)

See more:

SQL-Server-2008R2

, +

hi i want to insert data on one button click in multiple tables

i have tables like

1) custdetails
custid,custname,custadd,proid

2)proddetails
proid,prodname,price

3)branddetails
proid,brandname

now i want to insert in this three table
in using a storeprocedure like

SQL

Create PROCEDURE [dbo].[InsertDetails_SP]
(
                @custid varchar(50),
                   @custname varchar(50),
                   @custadd varchar(200),
              @proid int identity (1,1) ,
               @prodname varchar (50),
               @price int ,
               @brandname varchar (100) ,
               
)
as
begin
set nocount on;
begin transaction
insert into custdetails
(
custid,custname,custadd,proid
)
values
(
@custid,@custname,@custadd,proid
)
Declare @proid int 
set @proid=SCOPE_IDENTITY()
If @@ERROR=0
Begin
insert into proddetails
(
proid,prodname,price
)
values
(
@proid,@prodname,@price
)
end
if @@Error=0
begin
insert into branddetails(
proid,brandname
)
values
(
@proid,@brandname
)
IF @@ERROR = 0
				BEGIN			 
					COMMIT TRANSACTION
				END
			ELSE
				BEGIN			 
					ROLLBACK TRANSACTION		
				END
		END
ELSE
		BEGIN
			ROLLBACK TRANSACTION
		END
 
END

But am getting error that Must declare scalar variable for @brandname

please some one could you help me resolve this error...

Posted 24-Jun-15 1:07am

KansChweety

Updated 24-Jun-15 3:04am

F-ES Sitecore

v3

Add a Solution

Comments

ZurdoDev 24-Jun-15 7:41am

You don't declare @brandname anywhere which is why you get that error.

jaket-cp 24-Jun-15 8:20am

remove the comma after @brandname varchar (100)
see if that works.

KansChweety 24-Jun-15 8:31am

still have the same error must declare the scalar var fr brandname ..bt i declared above

Sreekanth Mothukuru 24-Jun-15 8:55am

Is this your actual running stored procedure? I see there are lot of syntax errors.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sandip.Nascar · Accepted Answer · 2015-06-24T18:44:00

Hi,

I see several errors Fixed the error and here is the code.
few errors I see
- int identity passing as input parameter
- comma after the last input parameter
- proid in insert statement ( no @)
- declaration of @proid multiple times

You can now charge the sp without any issue, but you need to look into the scrip that you have written everything correctly.

check the line - set @proid=SCOPE_IDENTITY()
looks incorrect

SQL

Create PROCEDURE [dbo].[InsertDetails_SP]
(
              @custid varchar(50),
              @custname varchar(50),
              @custadd varchar(200),
              @proid int,
              @prodname varchar (50),
              @price int ,
              @brandname varchar (100)
)
as
begin
set nocount on;
begin transaction
insert into custdetails
(
custid,custname,custadd,proid
)
values
(
@custid,@custname,@custadd,@proid
)
--Declare @proid int 
set @proid=SCOPE_IDENTITY()
If @@ERROR=0
Begin
insert into proddetails
(
proid,prodname,price
)
values
(
@proid,@prodname,@price
)
end
if @@Error=0
begin
insert into branddetails(
proid,brandname
)
values
(
@proid,@brandname
)
IF @@ERROR = 0
				BEGIN			 
					COMMIT TRANSACTION
				END
			ELSE
				BEGIN			 
					ROLLBACK TRANSACTION		
				END
		END
ELSE
		BEGIN
			ROLLBACK TRANSACTION
		END
 
END

Hope this helps