How do I display my new array?

Question

0.00/5 (No votes)

See more:

Hi all,

I am working a string consisting of 2 lines with characters 1 and 0.
I have placed the string into a string array to extract the lines.

Ideally, I would like to loop through this array and determine if the current element is 1 or 0. if it is a 1 I would like to place a '#' character into another array of type char. if it is a 0 I would like to place a 'X' so when i loop this new array i get a similar array but with the new characters.

For some reason, my char array doesn't print to screen, Could someone please point me in the right direction?

What I have tried:

class MainClass
    {
        const string maze = @"
            1 1 1 1 1
            1 0 0 0 1";
        
        public static void Main(string[] args)
        {
            //Display(GetMazeArray(maze));
            string[] lines = maze.Split(new char[] { '\n' },
                StringSplitOptions.RemoveEmptyEntries);

            char[][] characters = new char[2][];
            characters[0] = lines[0].ToCharArray();
            characters[1] = lines[1].ToCharArray();

            // new array to store the new characters
            char[][] newArr = new char[2][];

            for (int i = 0; i < 2; i++) 
            {
                for (int j = 0; j < 4; j++)
                {
                    if(characters[i][j] == '1')
                    {
                        newArr[i][j] = '#';
                    }
                    else if(characters[i][j] == '0')
                    {
                        newArr[i][j] = 'X';
                    }
                }
            }

            for (int i = 0; i < 2; i++)
            {
                for (int j = 0; j < 4; j++)
                {
                    Console.WriteLine(newArr[i][j]);
                }
            }
        }
}

Posted 8-May-18 9:12am

SCloudQ

Updated 8-May-18 10:46am

Add a Solution

2 solutions

Solution 2

You can reduce the amount of 'String creation and array manipulation like this:

private char[] splitary = new char[] {'\n','\r'};

// in some method:

StringBuilder sb = new StringBuilder(maze);
sb.Replace(" ", String.Empty);
sb.Replace('0', 'X');
sb.Replace('1', '#');

var trimmed = sb.ToString().Split(splitary, StringSplitOptions.RemoveEmptyEntries);

char[][] ary = new char[][]
{
    (trimmed[0].ToCharArray()),
    (trimmed[1].ToCharArray())
};

But, keep in mind that using an automatic Array initializer means you cannot specify the 'Length.

Posted 8-May-18 10:48am

BillWoodruff

Comments

Thomas Daniels 8-May-18 16:48pm

5; I was very focused on the errors but indeed, this is a much eleganter way to solve the whole problem.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thomas Daniels · Accepted Answer · 2018-05-08T09:29:00

There are three problems with your current code:

newArr[0] and newArr[1] are still null because you didn't assign empty arrays to these values yet. Do this:

C#

// new array to store the new characters
char[][] newArr = new char[2][];
newArr[0] = new char[characters[0].Length];
newArr[1] = new char[characters[1].Length];

.ToCharArray() will also give you a bunch of spaces in your characters array, which you don't want because you only are about 0 and 1. Remove the spaces first before using ToCharArray:

C#
```
char[][] characters = new char[2][];
characters[0] = lines[0].Replace(" ", "").ToCharArray();
characters[1] = lines[1].Replace(" ", "").ToCharArray();
```
You use j < 4 in your for loops; but your characters[i] arrays have 5 elements (the last index is 4) so you want j <= 4 or j < 5.

All these problems resolved:

C#

using System;

class MainClass
    {
        const string maze = @"
            1 1 1 1 1
            1 0 0 0 1";
        
        public static void Main(string[] args)
        {
            //Display(GetMazeArray(maze));
            string[] lines = maze.Split(new char[] { '\n' },
                StringSplitOptions.RemoveEmptyEntries);

            char[][] characters = new char[2][];
            characters[0] = lines[0].Replace(" ", "").ToCharArray();
            characters[1] = lines[1].Replace(" ", "").ToCharArray();

            // new array to store the new characters
            char[][] newArr = new char[2][];
            newArr[0] = new char[characters[0].Length];
            newArr[1] = new char[characters[1].Length];

            for (int i = 0; i < 2; i++) 
            {
                for (int j = 0; j < 5; j++)
                {
                    if(characters[i][j] == '1')
                    {
                        newArr[i][j] = '#';
                    }
                    else if(characters[i][j] == '0')
                    {
                        newArr[i][j] = 'X';
                    }
                }
            }

            for (int i = 0; i < 2; i++)
            {
                for (int j = 0; j < 5; j++)
                {
                    Console.WriteLine(newArr[i][j]);
                }
            }
        }
}