Whats wrong? I can not delete the row with button click

Question

1.00/5 (1 vote)

See more:

private void button4_Click(object sender, EventArgs e)
        {
            if (bar_code1DataGridView.SelectedRows.Count > 0)
            {

                DataGridViewRow dr = bar_code1DataGridView.SelectedRows[0];
                if (!string.IsNullOrEmpty(dr.Cells["dataGridViewTextBoxColumn1"].Value.ToString()))
                {

                    String cs = "Data Source=.\\SQLEXPRESS;Initial Catalog=barcode;Integrated Security=True";
                    using (SqlConnection openCon = new SqlConnection(cs))
                    {


                        using (SqlCommand querySaveStaff = new SqlCommand("DELETE FROM bar_code1 WHERE id=@id", openCon))
                        {

                            // querySaveStaff.Parameters.Add("@id",SqlDbType.Int).Value=idTextBox.Text;
                            querySaveStaff.Parameters.AddWithValue("@id", 0);
                            
                            openCon.Open();
                            querySaveStaff.ExecuteNonQuery();
                            openCon.Close();

                        }

                    }

                    using (SqlConnection openCon = new SqlConnection(cs))

                    {

                        string saveStaff = "SELECT * FROM dbo.bar_code1 ";
                        openCon.Open();
                        using (SqlDataAdapter querySaveStaff = new SqlDataAdapter(saveStaff, cs))
                        {
                            querySaveStaff.Fill(barcodeDataSet.bar_code1);
                            bar_code1DataGridView.DataSource = barcodeDataSet.bar_code1;
                            bar_code1DataGridView.Update();
                            bar_code1DataGridView.Refresh();
                        }

                    }
                }
            }
        }<pre lang="text">

What I have tried:

Whats wrong? I can not delete the row with button click

Posted 24-Jan-18 22:21pm

Goran Bibic

Updated 25-Jan-18 23:10pm

Add a Solution

2 solutions

Solution 1

Probably, it's that your ID value is fixed:

C#

using (SqlCommand querySaveStaff = new SqlCommand("DELETE FROM bar_code1 WHERE id=@id", openCon))
    {
    querySaveStaff.Parameters.AddWithValue("@id", 0);

Once you delete that row, you can't delete it again.
And as for your commented out code:

C#

querySaveStaff.Parameters.Add("@id",SqlDbType.Int).Value=idTextBox.Text;

That's not necessarily going to work either.
Instead, use int.TryParse at the top of your method to check and validate the user input, then use the converted value as the parameter.

C#

int id;
if (!int.TryParse(idTextBox.Text, out id))
   {
   ... report problem to user ... 
   return;
   }
...
querySaveStaff.Parameters.AddWithValue("@id", id);

But please, sort out your variable names! "querySaveStaff" deleting data? Not an obvious bit of self documentation!

Posted 24-Jan-18 22:29pm

OriginalGriff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Goran Bibic · Accepted Answer · 2018-01-25T22:10:00

private void button4_Click(object sender, EventArgs e)
       {
           int id;
           if (bar_code1DataGridView.SelectedRows.Count > 0)
           {

               DataGridViewRow dr = bar_code1DataGridView.SelectedRows[0];
               if (!int.TryParse(idTextBox.Text, out id))
               {

               String cs = "Data Source=.\\SQLEXPRESS;Initial Catalog=barcode;Integrated Security=True";
                   using (SqlConnection openCon = new SqlConnection(cs))
                   {


                       using (SqlCommand querySaveStaff = new SqlCommand("DELETE FROM bar_code1 WHERE id=@id", openCon))
                       {

                           // querySaveStaff.Parameters.Add("@id",SqlDbType.Int).Value=idTextBox.Text;
                           querySaveStaff.Parameters.AddWithValue("@id", id);

                           openCon.Open();
                           querySaveStaff.ExecuteNonQuery();
                           openCon.Close();

                       }




               }



               using (SqlConnection openCon = new SqlConnection(cs))

                   {

                       string saveStaff = "SELECT * FROM dbo.bar_code1 ";
                       openCon.Open();
                       using (SqlDataAdapter querySaveStaff = new SqlDataAdapter(saveStaff, cs))
                       {
                           querySaveStaff.Fill(barcodeDataSet.bar_code1);
                           bar_code1DataGridView.DataSource = barcodeDataSet.bar_code1;
                           bar_code1DataGridView.Update();
                           bar_code1DataGridView.Refresh();
                       }

                   }
               }


                       MessageBox.Show("Dont Work ");
                   return;


           }
       }