Extracticon function emits warning in VS2017

Question

0.00/5 (No votes)

See more:

Hi,

While migrating my code for VS 2008 to VS 2017 i am experiencing following warning for the ExtractIcon function. The code fragment goes like this,

C++

HMODULE hExeModule = ::GetModuleHandle(NULL);
HICON  hIcon = ::ExtractIcon(hExeModule, iconFileName, iconIndex);

The warning i am getting is
warning C6388: 'hExeModule' might not be '0': this does not adhere to the specification for the function 'ExtractIconW'.
It seems that the prototype for the ExtractIcon function is like this.

C++

SHSTDAPI_(HICON) ExtractIconW(_Reserved_ HINSTANCE hInst, _In_ LPCWSTR pszExeFileName, UINT nIconIndex);

Here the first parameter is _Reserved_ . I think it is causing the problem. Any idea what i should be doing to get it running.

What I have tried:

I have tried following code.

C++

HICON hIcon = NULL;
    HMODULE hExeModule = ::GetModuleHandle(NULL);
	if (hExeModule != NULL)
	{
		hIcon = ::ExtractIcon(hExeModule, iconFileName, iconIndex);
       }

Posted 6-Dec-17 20:27pm

PrafullaVedante

Updated 6-Dec-17 21:19pm

Add a Solution

2 solutions

Solution 1

See here: MSDN - C6388[^].

Posted 6-Dec-17 21:06pm

CPallini

Comments

PrafullaVedante 7-Dec-17 3:13am

Does that mean first parameter is redundant and should always sent as a NULL ?

CPallini 7-Dec-17 3:30am

Well, the _Reserved_ declaration, in sal.h header, gives a hint:
// Reserved pointer parameters, must always be NULL.
#define _Reserved_ _SAL2_Source_(_Reserved_, (), _Pre1_impl_(__null_impl))

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Accepted Answer · 2017-12-06T21:19:00

The warning is thrown because the parameter is declared as _Reserved_. In such cases NULL should be passed.

The ExtractIcon function (Windows)[^] documentation is unclear here. With other functions, the documentation usually states explicitly that the parameter should be NULL.

I suggest to pass NULL and check if an icon handle is returned. I expect that it will work because the "Handle to the instance of the application that calls the function" should be not required to load an icon from a specific file.