Error while returning value from function

Question

4.00/5 (1 vote)

See more:

Hello Friends,
Go through my code,

protected void Login1_Authenticate(object sender, AuthenticateEventArgs e)
    {
        clsUser objUser = new clsUser();
        Hashtable hstUser = new Hashtable();
        hstUser.Add("username", Login1.UserName);
        hstUser.Add("pwd", Login1.Password);
        objUser.setDetails(hstUser);

        if (Validate(objUser) == true)
        {
            Response.Redirect("..\\Pages\\frmRegistration.aspx");
        }
        else
            e.Authenticated = false;
    }
    private bool Validate(clsUser objUser) //Line1
    {
        UserBLL objUserBLL = new UserBLL();
        int intResult = objUserBLL.ValidateLogin(objUser);
        if(intResult > 0)
            return true;
        else if(intResult < 0)
            return false;
    }

I'm getting error at Line1 saying:

'_Default.Validate(clsUser)': not all code paths return a value	<br />

Can anyone help where I'm going wrong?

Thanks in advance.

Posted 3-May-11 23:51pm

dhage.prashant01

Add a Solution

2 solutions

Solution 1

write

return true

at the end of your validate function like

C#

private bool Validate(clsUser objUser) //Line1
    {
        UserBLL objUserBLL = new UserBLL();
        int intResult = objUserBLL.ValidateLogin(objUser);
        if(intResult > 0)
            return true;
        else if(intResult < 0)
            return false;
       return true;
    }

Posted 3-May-11 23:57pm

Ashishmau

Updated 3-May-11 23:59pm

v2

Comments

dhage.prashant01 4-May-11 5:59am

It gives another error: cannot convert null to bool

Ashishmau 4-May-11 6:00am

write return true instead of null

Toniyo Jackson 4-May-11 6:07am

Its not a correct way. What will happen if intResult < 0?

dhage.prashant01 4-May-11 6:18am

Thank U.
But may i know, what the error really mean?

dhage.prashant01 4-May-11 6:19am

yes its not working when intResult < 0.
Any other way

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Toniyo Jackson · Accepted Answer · 2011-05-04T00:05:00

Solution 2

If you declare a function to return a particular type of value (ie. something other than void), then you must ensure that all possible ways of exiting the function (implicit finish at the end of the function, or explicit with the use of a return statement) return a value compatible with the declared data type (eg. null would be compatible with both the string and Object data types).

Declare one variable and use it in return.

private bool Validate(clsUser objUser) //Line1
        {
            bool flag = false;

            UserBLL objUserBLL = new UserBLL();
            int intResult = objUserBLL.ValidateLogin(objUser);
            if (intResult > 0)
                flag = true;
            else if (intResult < 0)
                flag = false;

            return flag;
        }

Posted 4-May-11 0:05am

Toniyo Jackson

Updated 4-May-11 0:31am

v3

Comments

dhage.prashant01 4-May-11 6:21am

Thank You, but can u tell what does that error really meant?

Toniyo Jackson 4-May-11 6:27am

If you declare a function to return a particular type of value (ie. something other than void), then you must ensure that all possible ways of exiting the function (implicit finish at the end of the function, or explicit with the use of a return statement) return a value compatible with the declared data type (eg. null would be compatible with both the string and Object data types).

dhage.prashant01 4-May-11 6:35am

In my code there was two exit point, because when i removed if part from else clause my code working fine

Toniyo Jackson 4-May-11 6:38am

You have written if and else if condition. If these both conditions are not satisfying means what will happen? So there should a exit point.

dhage.prashant01 4-May-11 6:43am

Nice explanation.

Toniyo Jackson 4-May-11 6:31am

If it works Vote and Accept the answer.

Manfred Rudolf Bihy 4-May-11 6:23am

I prefer this way too! 5+

SPOE = Single point of entry/exit.

dhage.prashant01 4-May-11 6:25am

SPOE, not clear.
can anyone explain this error in simple words..?