Assigning number for all existing users

Question

1.00/5 (1 vote)

See more:

I have register 5 users in my app. I need assigning ramdom number for all of them but I cant

What I have tried:

public ActionResult Test(User user )
        {
            
            Random rand = new Random();
            int numero = rand.Next(1, 10000);
            var model = new User();

            model.UserId = user.UserId;
            model.Nombre = user.Nombre;                     
            model.Codigo = numero;

            
            db.Users.Add(model);
            db.SaveChanges();
            return View(model);
            
        }

Posted 17-Oct-17 15:46pm

NerakSeven

Updated 18-Oct-17 4:52am

Chris Maunder772.8K

v4

Add a Solution

Comments

Dave Kreskowiak 17-Oct-17 21:57pm

I don't know what "assing" means but it sounds not like it's not kid-sister-safe.

If you're talking about "assigning" numbers to users, the question becomes why?

NerakSeven 17-Oct-17 22:01pm

yes "assigning" sorry fr my english. I need it because it's like a password

Patrice T 17-Oct-17 22:08pm

Use Improve question to update your question.

Dave Kreskowiak 17-Oct-17 23:04pm

OK, so PIN numbers are usually a certain length. Your "random" number is anywhere between 1 and 4 digits long.

Did you want to tell everyone what the problem is?

NerakSeven 17-Oct-17 23:20pm

the problem is that the method creates a new record, not insert the PIN to existing users

RossMW 17-Oct-17 22:26pm

Normally you would store user info in a database, so depending on the database just set the user numeric value to the table unique ID field that is auto generated.

Why do you need a random number for a user?

NerakSeven 17-Oct-17 22:30pm

is not a ID , is like a temporary PIN for authentication

RossMW 17-Oct-17 22:39pm

The limited code you supplied appears OK. Maybe you need to step thru the code to find the issue and the error message or look for the problem in the rest of your code. There is inadequate info for us to determine the issue.

GKP1992 18-Oct-17 2:43am

Probably because you have the information of only one user in the action result method.
Do you think using a collection of user info to iterate through to assign them the random number and then saving/updating will do the trick?

Richard Deeming 18-Oct-17 15:00pm

REPOST
This is the same question you posted on Monday:
https://www.codeproject.com/Questions/1210800/How-I-do-a-method-to-assign-random-number-not-repe[^]

If you want to update your question, click the green "Improve question" link, and edit the question. DO NOT post the update as a new question!

NerakSeven 18-Oct-17 15:05pm

Ok sorry I didnt know

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Accepted Answer · 2017-10-18T04:52:00

OK, if you're trying to update an existing record, what do you think db.Users.Add does? Your code is specifically creating a new user and saving it to the table!

You have to retrieve the existing user object(s) from the database, assign the random numbers to them, then save the changes back to the database.

C#

Random rand = new Random();
var users = db.Users;

foreach (var user in users)
{
    // Assign a 4 digit PIN
    user.Codigo = rand.Next(1000, 10000);
}

db.SaveChanges();