Why does my min always print out 0?

Question

1.00/5 (1 vote)

See more:

First I ask the user to input 10 numbers, then I have to find the max and min of those numbers. I can print out the maximum number of my input, but for I can't figure out how to print my minimum number.

What I have tried:

Java

import java.util.Scanner;
public class App {

    public static void main(String[] args) {
        int[] minAndMax = new int[10];
        Scanner scan = new Scanner(System.in);
        
  
        int smallest = minAndMax[0];
        int largest = minAndMax[0];
       
        
        for(int i = 0; i < minAndMax.length; i++ )
        {
           System.out.print("Enter in a number: ");
           minAndMax[i] = scan.nextInt();
        }
      
        for (int i = 0; i < minAndMax.length; i++)
        {
            if(minAndMax[i] > largest)
                largest = minAndMax[i];
            
            /*else if (minAndMax[i] < smallest)
            {
                smallest = minAndMax[i];
            */
      
        }   
        for(int i = 0; i > minAndMax.length; i++ ) 
        {
            if (minAndMax[i] < smallest)
                smallest = minAndMax[i];
        }
       
        System.out.println("Maximum Number: " + largest);
        System.out.println("Minimum Number: " + smallest);
    }
    
}

Posted 11-Oct-17 8:27am

Member 13458860

Updated 11-Oct-17 9:41am

Add a Solution

Comments

Richard MacCutchan 11-Oct-17 15:35pm

In addition to OriginalGriff's comment you should set smallest equal to largest, before you start the second loop.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

cvogt61457 · Answer 1 · 2017-10-11T09:38:00

int smallest = minAndMax[0];

What is minAndMax[0] initialized to?

Set smallest to the largest possible value and largest to the smallest possible value.

int smallest = Integer.MAX_VALUE;
int largest = Integer.MIN_VALUE;

Normally, the default value an Integer will be initialized to will be 0 if you don't specify a value.
Unless you type in a negative number, you already have 0 in the smallest.
Uncomment the code in your first loop but don't use an else. Get rid of the second loop which has an error in the for statement - it's not needed.

for (int i = 0; i < minAndMax.length; i++)
{
    if(minAndMax[i] > largest)
        largest = minAndMax[i];        
    if (minAndMax[i] < smallest)
        smallest = minAndMax[i];
}

OriginalGriff · Answer 2 · 2017-10-11T09:15:00

Solution 1

Because your loop never enters the body:

for(int i = 0; i > minAndMax.length; i++ )

Change the > for a < - it should work.

Posted 11-Oct-17 9:15am

OriginalGriff

Patrice T · Answer 3 · 2017-10-11T09:40:00

You should try to set smallest and largest initial values after the user have entered the values.

There is a tool that allow you to see what your code is doing, its name is debugger. It is also a great learning tool because it show you reality and you can see which expectation match reality.
When you don't understand what your code is doing or why it does what it does, the answer is debugger.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]
http://docs.oracle.com/javase/7/docs/technotes/tools/windows/jdb.html[^]
https://www.jetbrains.com/idea/help/debugging-your-first-java-application.html[^]
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.

Why does my min always print out 0?

3 solutions

Solution 2

Solution 1

Solution 3

Add your solution here

Preview 0