Unable to add listview items after sorting colum

Question

0.00/5 (No votes)

See more:

Below is the code i am using for adding items to listview.

C#

OpenFileDialog FLoc = new OpenFileDialog();
           Application.DoEvents();
           FLoc.Title = "Select Host Name File";
           FLoc.Filter = "TXT files|*.txt";
           FLoc.InitialDirectory = @"C:\";

           if (FLoc.ShowDialog() == DialogResult.OK)
           {
               try
               {
                   FileName = FLoc.FileName;
                   FileLines = File.ReadAllLines(FileName);

                   if (listView1.Items.Count > 0)
                   {
                       foreach (ListViewItem itemR in listView1.Items)
                       {
                           itemR.Checked = false;
                           itemR.Remove();
                       }

                       int LC = 0;
                       foreach (var item1 in FileLines)
                       {
                           this.listView1.Focus();
                           LC = listView1.Items.IndexOf(listView1.Items.Add(item1));
                        //   listView1.Items[LC].SubItems.Add("");
                         //  listView1.Items[LC].Checked = true;

                       }
                       comboBox1.ResetText();
                       DTP.Value = DateTime.Today;

                   }
                   else
                   {


                       foreach (var item2 in FileLines)
                       {
                           //below condition to avoid duplicate entries in listview
                           //if (listView1.FindItemWithText(item) == null)
                           //{
                           int LC = listView1.Items.IndexOf(listView1.Items.Add(item2));
                           listView1.Items[LC].Checked = true;
                           //}


                       }
                   }

below is the class i am using for sorting listview column

C#

class ListViewItemComparer : IComparer
   {
       private int col;
       private System.Windows.Forms.SortOrder order;
       public ListViewItemComparer()
       {
           col = 0;
           order = System.Windows.Forms.SortOrder.Ascending;
       }
       public ListViewItemComparer(int column, System.Windows.Forms.SortOrder order)
       {
           col = column;
           this.order = order;
       }
       public int Compare(object x, object y)
       {
           int returnVal = -1;
           returnVal = String.Compare(((ListViewItem)x).SubItems[col].Text,
                                   ((ListViewItem)y).SubItems[col].Text);
           // Determine whether the sort order is descending.
           if (order == System.Windows.Forms.SortOrder.Descending)
               // Invert the value returned by String.Compare.
               returnVal *= -1;
           return returnVal;
       }
   }

after including this listview sorting column. if i try to sort columns then open the file to add items to listview getting a below error message. any help would much appreicated.

<br />
InvalidArgument=Value of '3' is not valid for 'index'. Parameter name: index<br />

What I have tried:

i have gone through all google pages but couldn't find any perfect solution.

Posted 4-Oct-17 1:47am

Member 13339377

Updated 4-Oct-17 3:48am

Add a Solution

Comments

GKP1992 4-Oct-17 8:18am

What do you mean by a perfect solution?

Member 13339377 4-Oct-17 8:39am

i am not sure what exactly causes this issue.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Member 13339377 · Answer 1 · 2017-10-04T03:48:00

Solution 1

finally found solution on myself. But the poor part is i am not sure how it works...

added the below line before the Listview Items remove part which resolved the issue

C#

listView1.Sorting = System.Windows.Forms.SortOrder.None;

P.S: May be before recreating listview items i settled the sorting in to NONE which resolves my issue.

Posted 4-Oct-17 3:48am

Member 13339377

Comments

Richard MacCutchan 4-Oct-17 10:08am

When you add items to a ListView that has SortOrder = Ascending or Descending, then it will try to sort each time you add an item. So as you capture the index value of each added item, the actual item's position may change. I found your code pretty convoluted to be honest, and I think perhaps it is over complicated. You should ignore the returned index values as you add items, and just do your sorting when all items have been added.