Cin skips and don't ask for value

Question

0.00/5 (No votes)

See more:

C++

class Order {
public:
	char customer[99];
	int numofOrd;
	int code[5];
	int quantity[5];

	void addOQ();
	bool updateOQ();
	void viewOQ();
};Order O[99];

void Order::addOQ() {
	char yn = 'y';
	cout << "Costumer Number " << orderNum;
	cout << "\nEnter customer name: ";
	cin >> O[orderNum].customer[99];
	cin.ignore('\n');
	
	for (int i = 1; tolower(yn) == 'y'; i++) {
		O[orderNum].numofOrd++;
		cout<< orderNum;
		cout << "Enter product code: ";
		cin >> O[orderNum].code[numofOrd];
			
		cout << "Enter quantity: ";
		cin >> O[orderNum].quantity[numofOrd];
		
		cout << "\nOrder added to queue\n";
		cout << "Add more?(Y|N)";
		cin >> yn;
	}
}

What I have tried:

It skips asking the code and quantity
what is wrong in this?
when i put cin.ignore the value doesn't store in the variable

Posted 19-Mar-17 21:56pm

Aeroneeee

Updated 19-Mar-17 22:14pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Michael_Davies · Answer 1 · 2017-03-19T22:14:00

Solution 1

The loop that gets the input has the condition to test yn equal to 'y', you initialise yn with 'y' therefore the condition is true and the loop does not execute even once.

Posted 19-Mar-17 22:14pm

Michael_Davies

Comments

Aeroneeee 20-Mar-17 4:31am

If I do this

char yn='y';
while(tolower(yn)=='y'){
O[orderNum].numofOrd++;

cout<< "Enter product code: ";
cin >> O[orderNum].code[numofOrd];

cout << "Enter quantity: ";
cin >> O[orderNum].quantity[numofOrd];

cout << "\nOrder added to queue\n";
cout << "Add more?(Y|N)";
cin >> yn;
}

the loop dont stop. I think the problem is in the cin?
It don't ask the user to enter value.

Michael_Davies 20-Mar-17 4:39am

Sorry, the loop should stop when you enter any character except y, are you saying it does not stop if you enter say an n?

If you want a loop to execute at least once use Do... While, it will test the condition after the code has executed rather than before.

Aeroneeee 20-Mar-17 4:52am

I tried that too but it won't prompt the user to enter any value.
But it prints the Enter code and Enter quantity.
It means that the loop runs ok.

Michael_Davies 20-Mar-17 4:59am

Does the cout for Add More not show, please be clear.

Pause the program before exit and copy the console text of a session and paste it here so we can see what is happening.

Aeroneeee 20-Mar-17 5:04am

void Order::addOQ() {
char yn = 'y';
cout << "Costumer Number " << orderNum;
cout << "\nEnter customer name: ";
cin >> O[orderNum].customer[99];

while(tolower(yn)=='y'){
O[orderNum].numofOrd++;

cout<< "Enter product code: ";
cin >> O[orderNum].code[numofOrd];

cout << "Enter quantity: ";
cin >> O[orderNum].quantity[numofOrd];

cout << "\nOrder added to queue\n";
cout << "Add more?(Y|N)";
cin >> yn;

system("pause");
}
}

The output is this

Costumer Number 1
Enter customer name: Finn
Enter product code: Enter quantity:
Order added to queue
Add more?(Y|N)Press any key to continue . . .
Enter product code: Enter quantity:
Order added to queue
Add more?(Y|N)Press any key to continue . . .
Enter product code: Enter quantity:
Order added to queue
Add more?(Y|N)Press any key to continue . . .

Aeroneeee 20-Mar-17 5:25am

Thanks for the help by the way :(

Michael_Davies 20-Mar-17 5:30am

What happens when you use the debugger to see the value in yn after you enter it.

Aeroneeee 20-Mar-17 5:32am

It show 0 errors and 0 warnings

Michael_Davies 20-Mar-17 5:42am

What value is in yn after you enter a non y character? Walking through ith a debugger you can see that value of the variable and verify it, alternatively echo yn after inputting it so it shows on the console.

Aeroneeee 20-Mar-17 5:48am

I initialize the value of yn = 'y' then when i run it, it wont ask for value.
Im sorry, I don't get it.

Aeroneeee 20-Mar-17 6:05am

It run now. I just remove the [99] from cin >> O[orderNum].customer;