Rounding and Adding not working

Question

1.00/5 (2 votes)

See more:

I have a form that Divides, Rounds and Adds. I got the Dividing and Rounding working but when trying to Add I get this error:

C#

Input string was not in a correct format.

On this line:

C#

int d = Convert.ToInt32(TextBoxTHGDR.Text.Replace(",", ""));

Here is the whole code behind:

C#

protected void TextBoxTHG_TextChanged(object sender, EventArgs e)
        {
            int i = Convert.ToInt32(TextBoxTHG.Text.Replace(",", ""));
            TextBoxTHGDR.Text = Convert.ToString(i / 9.0);

            int a = Convert.ToInt32(TextBoxFTUG.Text.Replace(",", ""));
            int b = Convert.ToInt32(TextBoxFTG.Text.Replace(",", ""));
            int c = Convert.ToInt32(TextBoxTHUGDR.Text.Replace(",", ""));
            int d = Convert.ToInt32(TextBoxTHGDR.Text.Replace(",", ""));
            TextBoxT1234.Text = Convert.ToString(a + b + c + d);
            TextBoxTHGDR.Text = Math.Round(Convert.ToDouble(TextBoxTHGDR.Text), 2).ToString();
            TextBoxTHGDR.Text = string.Format("{0:0,0}", double.Parse(TextBoxTHGDR.Text));
}

What is going on is that when a number is entered it is Divided, Rounded and Added with other numbers. How can I stop this error from happening? What did I miss?

Posted 7-Jan-16 5:53am

Computer Wiz99

Updated 7-Jan-16 6:14am

Manas_Kumar

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2016-01-07T06:19:00

Solution 1

First off, stop trying to use Convert.Int32 to deal with user input: use int.TryParse instead. It has an overload which allows thousands separators as the NumberStyles value:
https://msdn.microsoft.com/en-us/library/zf50za27%28v=vs.110%29.aspx?f=255&MSPPError=-2147217396[^]

Posted 7-Jan-16 6:19am

OriginalGriff

Manas_Kumar · Answer 2 · 2016-01-07T06:27:00

Solution 2

The exception means that the string you're trying to parse an integer from doesn't actually contain a valid integer.

The issue may be due to following reasons:

It may contains extra space. Use trim() function to delete unnecessary sapces.
String is not correct format means either it contains some alphanumeric, chars or special chars.

When your string should conatin only value from 0-9 except that it throw you exception.

You can use int.TryParse(). However if exception occurs you will get 0 as result.

C#

int finalResult;
bool output;
string str = "";
output = int.TryParse(str, out finalResult); // Here you wil get 0 as result

Posted 7-Jan-16 6:27am

Manas_Kumar

Comments

Computer Wiz99 7-Jan-16 12:38pm

Okay. I debugged it. Just letting it Divide and Round. I get the correct answer but it will not Add to the other numbers after the Rounding. No other charter is in the textbox. What now?

[no name] 7-Jan-16 12:41pm

What is the textbox value you are getting when debugging.

Computer Wiz99 7-Jan-16 12:48pm

When I enter 2204 I one textbox I get 245 in TextBoxTHGDR. Which is correct. But the other code that Adds each value when ever the value changes is throwing the error.

This code works:
int i = Convert.ToInt32(TextBoxTHG.Text.Replace(",", ""));
TextBoxTHGDR.Text = Convert.ToString(i / 9.0);

This code is throwing the error but at line d:
int a = Convert.ToInt32(TextBoxFTUG.Text.Replace(",", ""));
int b = Convert.ToInt32(TextBoxFTG.Text.Replace(",", ""));
int c = Convert.ToInt32(TextBoxTHUGDR.Text.Replace(",", ""));
int d = Convert.ToInt32(TextBoxTHGDR.Text.Replace(",", ""));
TextBoxT1234.Text = Convert.ToString(a + b + c + d);

Computer Wiz99 7-Jan-16 13:43pm

Where should I put the Trim()?