What's wrong in this?

Question

1.00/5 (3 votes)

See more:

C++

#include<iostream.h>
#include<stdio.h>
#include<string.h>
void main()
{
char a[20];
cout<<"Please enter the required password"<<endl;
cin>>a;
if (a=="strike"){
cout<<"access Granted!"<<endl;
} 
gets(a);
}

Posted 1-Sep-15 1:35am

Member 11950455

Updated 1-Sep-15 1:41am

CHill60

v2

Add a Solution

Comments

CHill60 1-Sep-15 7:41am

What happens when you run it? What were you expecting to happen?

Richard MacCutchan 1-Sep-15 7:45am

What's wrong? The attempt to read into an array, the comparison of a pointer to a string ...
You need to go back to your study notes and review the chapter(s) that you have been working on.

Member 11950455 1-Sep-15 8:23am

I expected access granted to display if strike was entered

Member 11950455 1-Sep-15 8:23am

a... actually i'm a beginner in this topic

Member 11950455 1-Sep-15 8:24am

please suggest me the correct programs!

chandanadhikari 1-Sep-15 9:39am

hi,
as already mentioned in the comments; try to learn the basics properly.
You can checkout following links; they explain concepts with working code samples:
http://www.cplusplus.com/
http://www.learncpp.com/

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

chandanadhikari · Answer 1 · 2015-09-01T03:27:00

Solution 1

hi,
you already know about string header file so instead of using char pointers directly, its better to use the strings like this :

C++

#include<iostream>

int main()
{
std::string userInput;
std::cout<<"Please enter the required password"<<std::endl;
std::getline(std::cin,userInput);

std::string actualPassword = "strike";

if(userInput == actualPassword)
std::cout<<"access Granted!"<<std::endl;

return 0;
}

still find out on your own how char array is different from std::string.Google is your friend.
and as already mentioned in comments, try to better your understanding of the concepts.

hope this helps !!

Posted 1-Sep-15 3:27am

chandanadhikari

Updated 1-Sep-15 14:05pm

v2

Comments

Member 11950455 2-Sep-15 8:03am

Thank you very much!!! could u please do me one more favour, please tell me what does this std:: stand for?? I haven't been using int main(), i'm using void main ()!

chandanadhikari 2-Sep-15 9:44am

hi,
first of all try to read about the basics of the language (i provided 2 links in my other comment)
Nobody is going to give you a crash course in C++ on codeproject. try to google out these things on your own and if you dont find anything useful then only post it here.
i'll give you some information but you have to search the web for more:
std is the standard namespace and when i want call a function defined within that namespace then its std::functionname. Now read/find out what is a namespace .
i used int main() as my compiler wont let me return void from main.
This might be confusing for a beginner. thats why take one step at a time and first learn the basics.