What's wrong with this code?

Question

0.00/5 (No votes)

See more:

Hello everyone, I have no C++ knowledge. I have the source code of a project and added these new lines to read IP and PORT values from Server section inside a ini file, and now I can't compile it. Can someone help me with this? Thank you.

C++

if (GetFileAttributes(gamepath.c_str()) != INVALID_FILE_ATTRIBUTES)
    {
        char ip[16];
        int port;

        GetPrivateProfileString(L"Server", L"IP", L"127.0.0.1", ip, _countof(ip), gamepath.c_str());
        GetPrivateProfileInt(L"Server", L"PORT", port, gamepath.c_str());
    }

char ip[16]; Error: argument of type "char*" is incompatible with parameter of type "LPWSTR"

Posted 15-May-15 20:37pm

froggz19

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

KarstenK · Answer 1 · 2015-05-15T22:32:00

Solution 1

You compile in Unicode so you cant use char. Use a unicode string or characters like wchar_t.

Posted 15-May-15 22:32pm

KarstenK

chandanadhikari · Answer 2 · 2015-05-15T22:48:00

Solution 2

hi,
the error message explains it :
the function expexts you tp pass an argument of type LPWSTR but you are passing it a char.
so please convert the ip[16] to LPWSTR and it should work.

The function mbstowcs[^] can help you out.

a rough example :

C++

char *mychar;
size_t nSize1 = 1 + strlen( mychar );
LPWSTR wUserName = new WCHAR[nSize1];
mbstowcs( wUserName, mychar, nSize1 );
  // use wUserName but after all the usage do remember delete it
delete []wUserName;

Check out this msdn link[^] for mbstowcs.

hope this helps !!

i dont know your whole code, this is all just hit and trial

C++

 char ip[16];
 size_t nSize1 = 1 + strlen( ip );
 LPWSTR wIPName = new WCHAR[nSize1];
 mbstowcs( wIPName, ip, nSize1 );
 //now wIPNmae has the string in required fromat
 GetPrivateProfileString(L"Server", L"IP", L"127.0.0.1", wIPName, _countof(ip),gamepath.c_str());
//the _countof() function is also using 'ip', i hope it does not complain
 
 //when you are done with wIPNmae then delete it
delete []wIPName;

Posted 15-May-15 22:48pm

chandanadhikari

Updated 15-May-15 23:46pm

v3

Comments

chandanadhikari 16-May-15 5:46am

comment out the line which gives error and try the new
code

froggz19 16-May-15 6:40am

Ok, tried again, thank you for trying to help me. Now the messagebox shows up saying Bad ip Configured.

if (GetFileAttributes(gamepath.c_str()) != INVALID_FILE_ATTRIBUTES)
{
char ip[16];
size_t nSize1 = 1 + strlen(ip);
LPWSTR wIPName = new WCHAR[nSize1];
mbstowcs(wIPName, ip, nSize1);
//now wIPName has the string in required fromat
//GetPrivateProfileString(L"Server", L"IP", L"127.0.0.1", wIPName, _countof(ip), gamepath.c_str());
//the _countof() function is also using 'ip', i hope it does not complain

//when you are done with wIPNmae then delete it

int port;

GetPrivateProfileString(L"Server", L"IP", L"127.0.0.1", wIPName, _countof(ip), gamepath.c_str());
delete[]wIPName;
GetPrivateProfileInt(L"Server", L"PORT", port, gamepath.c_str());

if (ip[0] == '\0')
{
MessageBox(nullptr, va(L"Bad ip configured! %s", ip), L"Error", MB_OK | MB_ICONERROR); // Shows this
ExitProcess(0);
}
else
{
Connect(ip, port);
}
}
else
{
MessageBox(nullptr, va(L"Unable to read ini"), L"Error", MB_OK | MB_ICONERROR);
ExitProcess(0);
}

froggz19 16-May-15 7:11am

I tried to convert using wcstombs (found something on google)

wchar_t ip[16];
char ipstr[16];
wcstombs(ipstr, ip, 16);

and called it

Connect(ipstr, port); but it didn't worked, it seems wchar_t is not being converted to normal char, it gives me a chinese letter or something if I call it with MessageBox(nullptr, LPCWSTR(ipstr), L"Error", MB_OK | MB_ICONERROR);

I tried MessageBox(nullptr, va(ip), L"Error", MB_OK | MB_ICONERROR); and it shows the ip inside the ini...