How to insert data datagridview rows values in sql server.

Question

0.00/5 (No votes)

See more:

My datagriview control having multiple rows like SNO, ITEM, DESCRIPTION, QUANTITY, when I am trying to insert datagridview's multiple rows in sql server it is taking top one row values and rest of the rows not inserting.following is my code block.
kindly suggest...thanks in advance

SqlConnection cn = new SqlConnection(constring);
           foreach (DataGridViewRow Row in dgvholidays.Rows)   //dgv holiday
           {
               if (Row.Cells[0].Value != null)
               {
                   int myear = Convert.ToInt32(Row.Cells[0].Value.ToString());
                   string holname =Convert.ToString(Row.Cells[1].Value);
                   DateTime dt = Convert.ToDateTime(Row.Cells[2].Value);   // Convert.ToInt32(Row.Cells[0].Value.ToString())
                   DateTime dt1 = Convert.ToDateTime(Row.Cells[3].Value);
                   int days = Convert.ToInt32(Row.Cells[4].Value.ToString());
                   dgvholidays.Columns[2].DefaultCellStyle.NullValue = string.Empty;
                   dgvholidays.Columns[3].DefaultCellStyle.NullValue = string.Empty;
                   SqlCommand cmd = new SqlCommand("Update Holiday set mYear='" + myear + "',holidayName='" + holname + "',dtFrom='" + dt.ToLongTimeString() + "',dtTo='" + dt1.ToLongTimeString() + "',tDays='" + days + "',Compcode='" + ccode + "' where IsActice=1", cn);
                   cmd.Connection.Open();
                   cmd.ExecuteNonQuery();
                   cmd.Connection.Close();
               }
           }

Posted 21-Apr-15 2:35am

Meer Wajeed Ali

Add a Solution

Comments

Richard Deeming 21-Apr-15 9:24am

Your code is vulnerable to SQL Injection[^].

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Suvendu Shekhar Giri · Accepted Answer · 2015-04-21T03:33:00

The shared code doesn't have the logic for insertion, instead it is meant for updation.
Note: I am using the answer section as you still have issue in the peiece of code you have shared here. Please have a look.

Hav a look at WHERE condition of your query. Are you are missing someting like-

SQL

WHERE IsActice=1 AND SomeId=@SomeId --IsActice or IsActive??

Your current query should update all the records with IsActice=1 and hence you should see the changes done only in the last updation.

Note: You should use parameterized query or stored procedure instead of inline queries to avoid SQL Injection.