How to retrieve image to picturebox using listbox

Question

1.00/5 (1 vote)

See more:

I stored some images in access db. But i am not able to retrieve and display in picture box. My code is like below. Everything is good but. Breaking at data set.
Please update me where i am doing wrong.

private void LoadPicture()
{
con.Open();
cmd.CommandText = "select picture from pictures where id ='" + listBox1.Text.ToString() + "'";
OleDbDataAdapter da = new OleDbDataAdapter(cmd);
OleDbCommandBuilder cbd = new OleDbCommandBuilder(da);
DataSet ds = new DataSet();

da.Fill(ds); //(getting Error Here)

con.Close();
byte[] ap = (byte[])(ds.Tables[0].Rows[0]["picture"]);
MemoryStream ms = new MemoryStream(ap);
pictureBox1.Image = Image.FromStream(ms);
pictureBox1.SizeMode = PictureBoxSizeMode.StretchImage;
pictureBox1.BorderStyle = BorderStyle.Fixed3D;
label1.Text = listBox1.Text.ToString();
ms.Close();
}
//Updated List Box like below.

private void listBox2_SelectedIndexChanged(object sender, EventArgs e)
{
ListBox l = sender as ListBox;
if(l.SelectedIndex != -1)
{
listBox1.SelectedIndex = l.SelectedIndex;
listBox2.SelectedIndex = l.SelectedIndex;
LoadPicture();
}
}

Posted 29-Dec-14 23:26pm

satya.Sw

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Ravi Bhavnani · Answer 1 · 2014-12-31T17:29:00

Solution 1

This statement is incorrect:

C#

cmd.CommandText = "select picture from pictures where id ='" +
                  listBox1.Text.ToString() +
                  "'";

It should read:

C#

cmd.CommandText = "select picture from pictures where id ='" +
                  listBox1.SelectedItem.Text +
                  "'";

Of course this assumes an item is selected in listBox1. Also, your code is guilty of SQL injection, but that's a whole different story.

/ravi

Posted 31-Dec-14 17:29pm

Ravi Bhavnani

Updated 31-Dec-14 17:30pm

v2

Comments

satya.Sw 1-Jan-15 19:27pm

Hi Boss.

Even I changed it. its not working. Please suggest me to get in other way.

My Requirement is to retrieve image from db to picturebox, using listbox.

Ravi Bhavnani 1-Jan-15 20:32pm

"its not working"
That doesn't tell me anything.

What happens when you debug the app? Is the query correct? Is the item not found in the database? Is there an exception thrown?

/ravi

satya.Sw 6-Jan-15 19:46pm

While Executing this Code I am Getting Error Like Below.

""An unhandled exception of type 'System.Data.OleDb.OleDbException' occurred in System.Data.dll""

""Additional information: Data type mismatch in criteria expression.""

How to overcome this Problem. Please Help me.

private void LoadPicture()
{
con.Open();
cmd.CommandText = "select picture from pictures where id ='" + listBox1.SelectedItem.ToString() + "'";
OleDbDataAdapter da = new OleDbDataAdapter(cmd);
OleDbCommandBuilder cbd = new OleDbCommandBuilder(da);
DataSet dst = new DataSet();
da.Fill(dst);
con.Close();
byte[] ap = (byte[])(dst.Tables[0].Rows[0]["picture"]);
MemoryStream ms = new MemoryStream(ap);
pictureBox1.Image = Image.FromStream(ms);
pictureBox1.SizeMode = PictureBoxSizeMode.StretchImage;
pictureBox1.BorderStyle = BorderStyle.Fixed3D;
label1.Text = listBox1.Text.ToString();
ms.Close();
}

Ravi Bhavnani 6-Jan-15 19:51pm

I'm not surprised. Your query is wrong. Look at my answer again.

/ravi

satya.Sw 6-Jan-15 20:02pm

Hi Boss,

cmd.CommandText = "select picture from pictures where id ='" +
listBox1.SelectedItem.Text +
"'";

After SelectedItem Keyword text is not accepting.
selectedItem.Tostring() is only there.

Even I tried. But its not allowing. It is sysntax Error.

Sorry boss. I am dotnet learner. If i am missing anything update me.

Ravi Bhavnani 6-Jan-15 20:07pm

I apologize. I was thinking ListView, not ListBox. Sorry.

SelectedItem.ToString() will work if the items in the list box are strings and the string is the format of the picture index (e.g. an integer). It should also work if the ListBox contains integers.

Please confirm this is the case and retry.

/ravi

satya.Sw 6-Jan-15 20:16pm

Thank You Sir,

But I saved image using bytes My code is like below.

private void savepicture()
{
if(pictureBox1.Image != null)
{
MemoryStream ms = new MemoryStream();
pictureBox1.Image.Save(ms, pictureBox1.Image.RawFormat);
byte[] a = ms.GetBuffer();
ms.Close();
cmd.Parameters.Clear();
cmd.Parameters.AddWithValue("@picture", a);
cmd.CommandText = "insert into pictures (name,picture) Values('"+label1.Text.ToString()+"', @picture)";
con.Open();
cmd.ExecuteNonQuery();
con.Close();
label1.Text = "";
pictureBox1.Image = null;
MessageBox.Show("success");
}
}

Ravi Bhavnani 6-Jan-15 20:20pm

Your INSERT statement implies the columns in your table are NAME and PICTURE, but your SELECT statement refers to the column ID. Of them seems incorrect. Fix and retry.

/ravi

satya.Sw 6-Jan-15 20:33pm

I took three of them(ID,Name,Image).
And Here I have taken 2 List boxes.

I am Freezed. Can You please give me a suggestion to insert data into access and retrieving Use of list box or list view.
If You have just provide me link i will follow and change my code according to that.

Thanks for your Patience.

satya.Sw 6-Jan-15 20:35pm

In listbox click selected event i have written below code.

private void listBox1_SelectedIndexChanged(object sender, EventArgs e)
{
ListBox l = sender as ListBox;
if (l.SelectedIndex != 0)
{
listBox1.SelectedIndex = l.SelectedIndex;
listBox1.Text = listBox1.SelectedIndex.ToString();
listBox2.SelectedIndex = l.SelectedIndex;
listBox2.Text = listBox2.SelectedIndex.ToString();
LoadPicture();
}

}

Ravi Bhavnani 6-Jan-15 20:55pm

Email me:
(1) a screenshot of SMSS showing the column definitions in your table (i.e. column names and their types)
(2) your C# project containing the Windows Forms app

My email address is ravib(at)ravib(dot)com.

/ravi