loop through a dataset and save values in sql server database using VB.net

Question

0.00/5 (No votes)

See more:

SQL-Server-2008R2

I am trying to loop through a dataset and save it in SQL server using VB.net.
But i am able to save only the first row in the dataset. Whats wrong?

VB

con.Open()

Dim cmd1 As SqlCommand

For Each Drr As DataRow In DtSet.Tables(0).Rows
    cmd1 = New SqlCommand("INSERT INTO Students (student_fullname, student_branch, student_scholarship) VALUES ('" & Drr(1).ToString & "', '" & Drr(2).ToString & "', '" & Drr(3).ToString & "')", con)
    cmd1.ExecuteNonQuery()
Next
MsgBox("Successfully Saved")
con.Close()

Posted 19-Nov-14 7:16am

hlsc1983

Add a Solution

Comments

PIEBALDconsult 19-Nov-14 13:28pm

That is nearly the worst way to do that on many levels.

Is there supposed to be one table with many rows? Or many tables with one row each?

Richard Deeming 19-Nov-14 13:43pm

Your code is vulnerable to SQL Injection[^].

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Thomas Rones 19-Feb-18 10:22am

Besides SQL injection, are there any reasons (performance?) not to use a concatenated string?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Manas Bhardwaj · Answer 1 · 2014-11-19T09:07:00

Solution 1

Irrespective of your question, Do you know that this implementation is susceptible of SQL Injection[^]?

I would suggest you to rather use Stored Procedure[^] or Parameterized Queries[^] in SQL.

Posted 19-Nov-14 9:07am

Manas Bhardwaj

Comments

PIEBALDconsult 19-Nov-14 15:25pm

No reason for stored procedures.

Manas Bhardwaj 19-Nov-14 15:29pm

Personally, I would any day use a SP instead of inline queries in C# code. That's another topic how that SP would be implemented. Accepting data in one go or if is it called everytime in a loop.

Having said that, ORMs are more a buzz these days. And would be more handy to have L2S or EF do that for you.

Maciej Los 19-Nov-14 16:02pm

Why?

[no name] 19-Nov-14 19:37pm

*lol* I agree. Nobody is willing to use the minimal SQL9x but everybody is willing to make MSQL-specific stored proc....

PIEBALDconsult 19-Nov-14 19:44pm

Indeed, and the inexperienced keep touting them as the bestest thing since 16-bit operating systems, that they fix all problems just by looking at them.
A plague upon the land they are.

[no name] 19-Nov-14 20:19pm

But still, please be a little soft with us 8 bit damaged dinosaurs. It takes some time to learn all these new stuff...

http://nicephore.hautetfort.com/media/02/01/2242486971.jpg[^]

:)
Bruno

PIEBALDconsult 19-Nov-14 20:48pm

But we don't _need_ to learn the "new stuff" -- the old stuff still works and is more stable than the stuff-du-jour.

[no name] 19-Nov-14 21:03pm

je suis d'accord/I agree.

Maciej Los 19-Nov-14 16:02pm

+5!

Manas Bhardwaj 19-Nov-14 16:04pm

thx Maciej :)

PIEBALDconsult · Answer 2 · 2014-11-19T13:23:00

Try something more like this (what I show may not be exactly correct for your needs). If you need to loop through more tables in the set then add another loop.

C#

con.Open()
 
Dim cmd1 As SqlCommand
    cmd1 = New SqlCommand("INSERT INTO Students (student_fullname, student_branch, student_scholarship) VALUES (@student_fullname, @student_branch, @student_scholarship)", con)

cmd1.Parameters.Add ( new SqlParameter ( @student_fullname    , nothing ) )
cmd1.Parameters.Add ( new SqlParameter ( @student_branch      , nothing ) )
cmd1.Parameters.Add ( new SqlParameter ( @student_scholarship , nothing ) ) 

For Each Drr As DataRow In DtSet.Tables(0).Rows
    cmd1.Parameters ( @student_fullname    ).Value = Drr(1) 
    cmd1.Parameters ( @student_branch      ).Value = Drr(2) 
    cmd1.Parameters ( @student_scholarship ).Value = Drr(3) 

    cmd1.ExecuteNonQuery()
Next
MsgBox("Successfully Saved")
con.Close()