Adding sql parmeter with the same name

Question

4.00/5 (1 vote)

See more:

first of all sorry about my english
Based on a condition i need to insert a row . i have to insert the row three times
i am having three checkboxes. and i am generating random integer for my subscription id. if the check box is true i am adding parameters to it but it is generating error

error : the variable name '@subid' has already been declared. variable names must be unique within a query batch or stored procedures

Code :

C#

string insertsubscriptionquery = " INSERT INTO Subscription(SubscriptionId,TypeOfMagazine) values (@subid,@TypeOfMagazine)";
SqlCommand subcmd = new SqlCommand(insertsubscriptionquery,connstring);
if (checkbox1.IsChecked == true)
                {
                    subcmd.Parameters.AddWithValue("@subid", subscripid1);
                    subcmd.Parameters.AddWithValue("@TypeOfMagazine", magtype1);
                     subcmd.ExecuteNonQuery();
                     
                }
                if (checkbox2.IsChecked == true)
                {
                    subcmd.Parameters.AddWithValue("@subid", subscripid2);
                    subcmd.Parameters.AddWithValue("@TypeOfMagazine", magtype2);
                    subcmd.ExecuteNonQuery();
                    
                }
                if (checkbox3.IsChecked == true)
                {
                    subcmd.Parameters.AddWithValue("@subid", subscipid3);
                    subcmd.Parameters.AddWithValue("@TypeOfMagazine", magtype3);
                    subcmd.ExecuteNonQuery();
                    noofrows++;
                }

subscription id is a primary key

How to insert all values at the same time

Posted 9-Mar-11 1:02am

narutouzamaki

Add a Solution

2 solutions

Solution 1

The problem is that when you execute the first one, you set the parameters. When you then try to execute the second, the command exists and has the parameters set already if checkbox1 is checked.

I would do it slightly differently:

C#

private string insertsubscriptionquery = " INSERT INTO Subscription(SubscriptionId,TypeOfMagazine) values (@subid,@TypeOfMagazine)";
private static void InsertIfRequired(bool required, object id, object magazineType)
   {
   using (SqlCommand subcmd = new SqlCommand(insertsubscriptionquery,connstring))
      {
      if (required)
         {
         subcmd.Parameters.AddWithValue("@subid", id);
         subcmd.Parameters.AddWithValue("@TypeOfMagazine", magazineType);
         subcmd.ExecuteNonQuery();
         }
      }
   }

...
                InsertIfRequired(checkbox1.IsChecked, subscripid1, magtype1);
                InsertIfRequired(checkbox2.IsChecked, subscripid2, magtype2);
                InsertIfRequired(checkbox3.IsChecked, subscripid3, magtype3);
...

You can replace the object parameters with the appropriate type.

Posted 9-Mar-11 1:16am

OriginalGriff

Comments

Costica U 9-Mar-11 7:43am

I like your solution. My 5

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Costica U · Accepted Answer · 2011-03-09T01:17:00

Change

C#

if (checkbox2.IsChecked == true)
{
    if(subcmd.Parameters.Contains("@subid"))
    {
       subcmd.Parameters["@subid"].Value=subscripid2;
    }
    else
    {
      subcmd.Parameters.AddWithValue("@subid", subscripid2);
    }
    if(subcmd.Parameters.Contains("@TypeOfMagazine"))
    {
       subcmd.Parameters["@TypeOfMagazine"].Value=magtype2;
    }
    else
    {
      subcmd.Parameters.AddWithValue("@TypeOfMagazine", magtype2);
    }
    subcmd.ExecuteNonQuery();
}

Same for if (checkbox3.IsChecked == true)

Also you increment noofrows only if checkbox3.IsChecked == true, is this wanted?.