Why my program doesn't execute if else correctly ?

Question

1.00/5 (2 votes)

See more:

Hello, I am testing on three different conditions;
First one is the selectedIndex of the dropDown1==2 and the TextBox is empty
Second is the selectedIndex of the DropDown1==2 and the TextBox is not empty
Last one is the selectedIndex of the dropDown ==3
When executing It goes directly to the Last condition and doesnt even test the first ones.

This is my code

C#

protected void btnValider_Click(object sender, EventArgs e)
{
    if (cmbStatut.SelectedIndex == 2)
    {
        if (txtNvSt.Text != null)
        {
            con.charger("update Materiel set reparation= NULL where serviceTag='" + txtServiceTag.Text + "'", false);
            Session["ST"] = txtNvSt.Text;
            Response.Redirect("NouveauMAt.aspx");
        }
        else
            if (txtNvSt.Text == null)
            {
                con.charger("insert into Stocker values('1', '" + txtServiceTag.Text + "')", false);
            }
    }
    else
    {
        con.charger("update Materiel set reparation = NULL, idEmplacement = NULL where serviceTag='" + txtServiceTag.Text + "'", false);
        Response.Redirect("StockHS.aspx");
    }
}

Posted 1-Jul-14 5:04am

Member 10889990

Updated 1-Jul-14 5:28am

Debabrata_Das

v2

Add a Solution

Comments

[no name] 1-Jul-14 11:18am

It's will go to your last condition if your selected index is anything except 2
Text will never be null so those condition will never be satisfied.

PIEBALDconsult 1-Jul-14 11:24am

It's doing exactly what you told it to do. Your code doesn't match your spec.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2014-07-01T05:20:00

The property Text is never null. It could be empty, could contain only blank spaces, and so on. If you need to test if some entered data is empty, you can do this

C#

if (txtNvSt.Text == string.Empty) //...

or

C#

if (string.IsNullOrEmpty(txtNvSt.Text)) //...

Also, you may want to consider something like

C#

if (txtNvSt.Text.Trim() != string.Empty) //...

The first and last fragment essentially based on assumption that txtNvSt.Text is never null. In other cases where null is possible you should also check for null.

To see what part of your code is really executed, in case of even slightest doubt, always use the debugger. It will also tell you which part of condition is true or false. :-)

—SA

George Jonsson · Accepted Answer · 2014-07-01T05:21:00

Your string is probably not null, but empty.
Use String.IsNullOrEmpty()

C#

protected void btnValider_Click(object sender, EventArgs e)
{
  if (cmbStatut.SelectedIndex == 2)
  {
    if (!String.IsNullOrEmpty(txtNvSt.Text))
    { 
       con.charger("update Materiel set reparation= NULL where serviceTag='" + txtServiceTag.Text + "'", false);
       Session["ST"] = txtNvSt.Text;
       Response.Redirect("NouveauMAt.aspx");
     }
     else
     { 
       con.charger("insert into Stocker values('1', '" + txtServiceTag.Text + "')", false);
     }
   }
   else if (cmbStatut.SelectedIndex == 3)
   {
     con.charger("update Materiel set reparation = NULL, idEmplacement = NULL where serviceTag='" + txtServiceTag.Text + "'", false);
     Response.Redirect("StockHS.aspx");
   }
   else
  {
      // Unsupported case
  }
}

Debabrata_Das · Accepted Answer · 2014-07-01T05:37:00

In addition to the other solutions provided by SA and George, you may use switch-case statements instead of if-else which looks more structured:

C#

protected void btnValider_Click(object sender, EventArgs e)
{
    switch (cmbStatut.SelectedIndex)
    {
        case 2:
            if (!string.IsNullOrEmpty(txtNvSt.Text))
            {
                con.charger("update Materiel set reparation= NULL where serviceTag='"
                            + txtServiceTag.Text + "'", false);
                Session["ST"] = txtNvSt.Text;
                Response.Redirect("NouveauMAt.aspx");
            }
            else
            {
                con.charger("insert into Stocker values('1', '"
                            + txtServiceTag.Text + "')", false);
            }

            break;

        case 3:
            con.charger("update Materiel set reparation = NULL, idEmplacement = NULL where serviceTag='"
                        + txtServiceTag.Text + "'", false);
            Response.Redirect("StockHS.aspx");

            break;

        default:
            // Write code here to handle any other value
    }
}

Why my program doesn't execute if else correctly ?

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0