database can't be updated. plz help me

Question

1.00/5 (1 vote)

See more:

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.SqlClient;

public partial class _Default : System.Web.UI.Page
{
        SqlConnection conn = new SqlConnection("server=DIPESH-PC\\SQLEXPRESS;uid=sa;pwd=rerf;database=Employee");
        SqlConnection con1 = new SqlConnection("server=DIPESH-PC\\SQLEXPRESS;uid=sa;pwd=rerf;database=Employee");
    protected void Page_Load(object sender, EventArgs e)
    {
        SqlCommand cmd = new SqlCommand("select * from tbl_emp", con1);
        SqlDataReader reader;
        con1.Open();
        reader = cmd.ExecuteReader();
        reader.Read();
        TextBox1.Text = reader["email"].ToString();
        TextBox2.Text = reader["password"].ToString();
        TextBox3.Text = reader["Address"].ToString();
        
        reader.Close();
        con1.Close();
    }
    protected void Button1_Click(object sender, EventArgs e)
{
    this.TextBox1.ReadOnly = true;
    this.TextBox2.ReadOnly = false;
    this.TextBox3.ReadOnly = false;

}
    protected void Button2_Click(object sender, EventArgs e)
    {

        conn.Open();
        SqlCommand cmd1= new SqlCommand("UPDATE tbl_emp SET password=@password, Address=@Address WHERE email=@email",conn);
        cmd1.Parameters.AddWithValue("@password",TextBox2.Text);
        cmd1.Parameters.AddWithValue("@Address", TextBox3.Text);
        cmd1.Parameters.AddWithValue("@email", TextBox1.Text);
        cmd1.ExecuteNonQuery();
        conn.Close();            
        Label1.Text = "  Data Updates Succesfully on  " + System.DateTime.Now.ToShortDateString();
             
    }
   
}

Label1 message displayed ' Data Updates Succesfully on................' but database can't be updated. plz help me

Posted 2-May-14 12:26pm

dipesh_karmakar

Updated 2-May-14 20:15pm

Rahul VB

v3

Add a Solution

Comments

PIEBALDconsult 2-May-14 20:55pm

Check the result of the ExecuteNonQuery.

[no name] 2-May-14 23:15pm

How can you possibly know if the update is successful or not when you don't check? And you probably need to enclose "password" in brackets, [password]

And why on your Page_Load do you select everything from your table when you only use one single record? Doesn't that seem a bit wasteful to you?

dipesh_karmakar 4-May-14 15:30pm

conn.Open();
SqlCommand cmd1 = new SqlCommand("UPDATE tbl_emp SET [password]=@password,[Address]=@Address WHERE[email]=@email", conn);
cmd1.Parameters.AddWithValue("@password", TextBox2.Text);
cmd1.Parameters.AddWithValue("@Address", TextBox3.Text);
cmd1.Parameters.AddWithValue("@email", TextBox1.Text);
cmd1.ExecuteNonQuery();
conn.Close();
Label1.Text = " Data Updates Succesfully on " + System.DateTime.Now.ToShortDateString();

dipesh_karmakar 4-May-14 15:32pm

but still i got error. database can't updated

King Fisher 3-May-14 0:11am

catch the Exception.

dipesh_karmakar 4-May-14 15:34pm

how to catch the Exception...

dipesh_karmakar 4-May-14 15:35pm

using try and catch block

King Fisher 5-May-14 0:09am

yeah

dipesh_karmakar 5-May-14 0:30am

but still now got error ...

King Fisher 5-May-14 0:37am

what is the Error?

dipesh_karmakar 5-May-14 0:59am

protected void Button2_Click(object sender, EventArgs e)
{
conn.Open();
SqlCommand cmd1 = new SqlCommand("UPDATE tbl_emp SET [password]=@password,[Address]=@Address WHERE[email]=@email", conn);
cmd1.Parameters.AddWithValue("@password", TextBox2.Text);
cmd1.Parameters.AddWithValue("@Address", TextBox3.Text);
cmd1.Parameters.AddWithValue("@email", TextBox1.Text);
cmd1.ExecuteNonQuery();
conn.Close();
Label1.Text = " Data Updates Succesfully on " + System.DateTime.Now.ToShortDateString();

}

dipesh_karmakar 5-May-14 1:02am

Label1 message displayed but originally database can't updated ...........
i also using try catch block uses .........but still same problem

dipesh_karmakar 5-May-14 1:20am

protected void Button2_Click(object sender, EventArgs e)
{
try
{
conn.Open();
SqlCommand cmd1 = new SqlCommand("UPDATE tbl_emp SET [password]=@password,[Address]=@Address WHERE[email]=@email", conn);
cmd1.Parameters.AddWithValue("@password", TextBox2.Text);
cmd1.Parameters.AddWithValue("@Address", TextBox3.Text);
cmd1.Parameters.AddWithValue("@email", TextBox1.Text);
cmd1.ExecuteNonQuery();
conn.Close();
Label1.Text = " Data Updates Succesfully on " + System.DateTime.Now.ToShortDateString();

}
catch (Exception ex) {
Response.Write(ex.ToString());
}
}

King Fisher 5-May-14 1:08am

try
{conn.Open();
SqlCommand cmd1 = new SqlCommand("UPDATE tbl_emp SET [password]=@password,[Address]=@Address WHERE[email]=@email", conn);
cmd1.Parameters.AddWithValue("@password", TextBox2.Text);
cmd1.Parameters.AddWithValue("@Address", TextBox3.Text);
cmd1.Parameters.AddWithValue("@email", TextBox1.Text);
cmd1.ExecuteNonQuery();
conn.Close();
}
catch (Exception ex)
{
Response.Write(ex.ToString());
}

dipesh_karmakar 5-May-14 1:21am

i also using try catch block ........but still same problem

dipesh_karmakar 5-May-14 1:23am

dipesh.karmakar00@gmail.com is my email address plz send me a blank mail and i will send my projects

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

frostcox · Answer 1 · 2014-05-02T12:49:00

Hey,

Id'd put a try catch around the whole statement in Button2_Click and see if any exceptions were thrown.

Also its good coding practice to wrap any classes which implement IDisposable in using statements so your method would become:

using (conn)
{
    conn.Open();

    using (SqlTransaction objTrans = conn.BeginTransaction())
    {
        try
        {
            using (SqlCommand cmd1 = new SqlCommand("UPDATE tbl_emp SET password=@password, Address=@Address WHERE email=@email", conn))
            {
                cmd1.Parameters.AddWithValue("@password", "");
                cmd1.Parameters.AddWithValue("@Address", "");
                cmd1.Parameters.AddWithValue("@email", "");
                cmd1.ExecuteNonQuery();

                objTrans.Commit();
            }
        }
        catch (SqlException ex)
        {
            //Display error here
            objTrans.Rollback();
        }

        Label1.Text " Data Updates Succesfully on " + System.DateTime.Now.ToShortDateString();

    }

}

Also I would wrap the update in a transaction just to be safe, apologies if there are some syntax mistakes as I wrote it free hand but you get the idea.