Click here to Skip to main content
15,886,199 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
the below code i have applied on button
C#
protected void Submit_Button_Click(object sender, EventArgs e)
       {
           string connString = ConfigurationManager.ConnectionStrings["conString"].ConnectionString;
           SqlConnection con = null;
           try
           {
               con = new SqlConnection(connString);
               using (SqlCommand cmd = new SqlCommand())
               {
                   cmd.Connection = con;
                   cmd.CommandType = CommandType.Text;
                   cmd.CommandText = "INSERT INTO  EmployeeProjects (ProjectId,EmployeeId,Date,NoOfPage,Deadline,IsDeleted,CreatedOn,CreatedBy,UpdatedOn,UpdatedBy)values(@ProjectId,@EmployeeId,@Date,@NoOfPages,@Date,@Deadline,@IsActive,@CreatedOn,@CreatedBy,@UpdatedOn,@UpdatedBy)";
                   cmd.Parameters.AddWithValue("@ProjectId", ProjectId_TB.Text.Trim());
                   cmd.Parameters.AddWithValue("@EmployeeId", EmployeeId_TB.Text.Trim());
                    cmd.Parameters.AddWithValue("@Date", Date_TB.Text.Trim());
                   cmd.Parameters.AddWithValue("@NoOfPage", NoOfPages_TB.Text.Trim());

                   cmd.Parameters.AddWithValue("@Deadline", Deadline_TB.Text.Trim());

                   cmd.Parameters.AddWithValue("@CreatedOn", CreatedBy_TB.Text.Trim());
                   cmd.Parameters.AddWithValue("@CreatedBy", CreatedBy_TB.Text.Trim());
                   cmd.Parameters.AddWithValue("@UpdatedOn", UpdatedOn_TB.Text.Trim());
                   cmd.Parameters.AddWithValue("@UpdatedBy", UpdatedBy_TB.Text.Trim());
                   cmd.Parameters.AddWithValue("@IsDeleted", IsDeleted_TB.Text.Trim());
                   int rowsAffected = cmd.ExecuteNonQuery();
                   if (rowsAffected == 1)
                   {
                       Label1.Text = "registered successful.";
                   }
                   else
                   {
                       //Error notification
                   }

               }
           }
           catch (Exception ex)
           {
               //log error
               //display friendly error to user
           }
           finally
           {
               if (con != null)
               {
                   //cleanup connection i.e close
               }
           }
       }




and this is my Connection string
XML
<connectionStrings>
        <add name="conString" connectionString="Data Source=.\SQLEXPRESS;AttachDbFilename=D:\Amplits\CelebralProspectus\AssignProject\AssignProject\App_Data\celebral.mdf;Integrated Security=True;User Instance=True"/></connectionStrings>
Posted
Updated 20-Mar-14 7:22am
v2
Comments
Richard C Bishop 20-Mar-14 13:18pm    
But what?
ramshamuzaffer 20-Mar-14 13:21pm    
but not inserting data Richard
JoCodes 20-Mar-14 13:23pm    
But? then what happened?
ramshamuzaffer 20-Mar-14 13:25pm    
nothing .. :/ screen remain as it is .. it is not giving any error :/
JoCodes 20-Mar-14 13:34pm    
Have tried to debug the code?

Run the same query in Sql Server Studio and check if a record inserts or not.
That should give you an idea if this is an error with your query.
 
Share this answer
 
check your parameters correctly
@IsActive , @IsDeleted

C#
cmd.CommandText = "INSERT INTO  EmployeeProjects (ProjectId,EmployeeId,Date,NoOfPage,Deadline,IsDeleted,CreatedOn,CreatedBy,UpdatedOn,UpdatedBy)values(@ProjectId,@EmployeeId,@Date,@NoOfPages,@Date,@Deadline,@IsActive,@CreatedOn,@CreatedBy,@UpdatedOn,@UpdatedBy)";
                   
Checkout here above You have taken @IsActive instead of @IsDeleted

cmd.Parameters.AddWithValue("@ProjectId", ProjectId_TB.Text.Trim());
                   cmd.Parameters.AddWithValue("@EmployeeId", EmployeeId_TB.Text.Trim());
                    cmd.Parameters.AddWithValue("@Date", Date_TB.Text.Trim());
                   cmd.Parameters.AddWithValue("@NoOfPage", NoOfPages_TB.Text.Trim());
 
                   cmd.Parameters.AddWithValue("@Deadline", Deadline_TB.Text.Trim());
 
                   cmd.Parameters.AddWithValue("@CreatedOn", CreatedBy_TB.Text.Trim());
                   cmd.Parameters.AddWithValue("@CreatedBy", CreatedBy_TB.Text.Trim());
                   cmd.Parameters.AddWithValue("@UpdatedOn", UpdatedOn_TB.Text.Trim());
                   cmd.Parameters.AddWithValue("@UpdatedBy", UpdatedBy_TB.Text.Trim());
                   cmd.Parameters.AddWithValue("@IsDeleted", IsDeleted_TB.Text.Trim());
 
Share this answer
 
Hai
Did u check ur code with break point ? if u click Submit_Button it fire Submit_Button_Click event,i mean break point goes inside of Submit_Button_click ? try to change ur button name as Submit,don't give underscore for ur button name.
 
Share this answer
 
You need to Open() the connection before you can ExecuteNonQuery() the command.

C#
using (SqlConnection con = new SqlConnection(connString))
using (SqlCommand cmd = new SqlCommand())
{
    cmd.Connection = con;
    cmd.CommandType = CommandType.Text;
    cmd.CommandText = "INSERT INTO  EmployeeProjects (ProjectId, EmployeeId, Date, NoOfPage, Deadline, IsDeleted, CreatedOn, CreatedBy, UpdatedOn, UpdatedBy) values (@ProjectId, @EmployeeId, @Date, @NoOfPages, @Date, @Deadline, @IsActive, @CreatedOn, @CreatedBy, @UpdatedOn, @UpdatedBy)";
    cmd.Parameters.AddWithValue("@ProjectId", ProjectId_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@EmployeeId", EmployeeId_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@Date", Date_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@NoOfPage", NoOfPages_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@Deadline", Deadline_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@CreatedOn", CreatedBy_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@CreatedBy", CreatedBy_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@UpdatedOn", UpdatedOn_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@UpdatedBy", UpdatedBy_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@IsDeleted", IsDeleted_TB.Text.Trim());  
    
    con.Open();
    int rowsAffected = cmd.ExecuteNonQuery();
    ... 
}
 
Share this answer
 
In addition to Solution #2, I would change your using statement to:
using (SqlConnection con = new SqlConnection(connString))
{
    SqlCommand cmd = new SqlCommand();
    cmd.Connection = con;
    cmd.CommandType = CommandType.Text;
    cmd.CommandText = "INSERT INTO  EmployeeProjects (ProjectId, EmployeeId, Date, NoOfPage, Deadline, IsDeleted, CreatedOn, CreatedBy, UpdatedOn, UpdatedBy) values(@ProjectId, @EmployeeId, @Date, @NoOfPages, @Date, @Deadline, @IsActive, @CreatedOn, @CreatedBy, @UpdatedOn, @UpdatedBy)";
    cmd.Parameters.AddWithValue("@ProjectId", ProjectId_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@EmployeeId", EmployeeId_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@Date", Date_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@NoOfPage", NoOfPages_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@Deadline", Deadline_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@CreatedOn", CreatedBy_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@CreatedBy", CreatedBy_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@UpdatedOn", UpdatedOn_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@UpdatedBy", UpdatedBy_TB.Text.Trim());
    cmd.Parameters.AddWithValue("@IsDeleted", IsDeleted_TB.Text.Trim());  
    
    con.Open();
    int rowsAffected = cmd.ExecuteNonQuery();

}

This is done so that your connection is closed after the application leaves the scope of the using statement.



I would recommend adding a space after the closing parenthesis of the column names in your insert statement and "values":
cmd.CommandText = "INSERT INTO  EmployeeProjects (ProjectId, EmployeeId, Date, NoOfPage, Deadline, IsDeleted, CreatedOn, CreatedBy, UpdatedOn, UpdatedBy) values(@ProjectId, @EmployeeId, @Date, @NoOfPages, @Date, @Deadline, @IsActive, @CreatedOn, @CreatedBy, @UpdatedOn, @UpdatedBy)";
 
Share this answer
 
v2
Comments
Richard Deeming 20-Mar-14 13:53pm    
I'd already put the connection in a "using" block; all you've done is take the command out of the "using" block.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900