problem with saving files from different locations

Question

0.00/5 (No votes)

See more:

I have this code for saving files into sql server

public byte[] ReadDoc(string document)
{
byte[] DocData = null;
DirectoryInfo dirInfo = new DirectoryInfo(document);
foreach (FileInfo f in dirInfo.GetFiles())
{
long DocFileLength = f.Length;
FileStream fs1 = new FileStream(document, FileMode.Open, FileAccess.Read);
BinaryReader br1 = new BinaryReader(fs1);
DocData = br1.ReadBytes((int)DocFileLength);
}

return DocData;

}
and on save button event I have

if (listOfLoadedFiles.Items.Count != 0)
{
byte[] fileData = null;

foreach (ListViewItem item in listOfLoadedFiles.Items)
{

string extension = Path.GetExtension(item.Text);

fileData = ReadDoc(item.Text);

daData2.InsertCommand = new SqlCommand("INSERT INTO Documents VALUES (@Documents, @patternID, @userID, @documentName, @extension)", cs);

daData2.InsertCommand.Parameters.Add("@Documents", SqlDbType.VarBinary).Value = fileData;
daData2.InsertCommand.Parameters.Add("@patternID", SqlDbType.NVarChar).Value = patternID.Text;
daData2.InsertCommand.Parameters.Add("@userID", SqlDbType.NVarChar).Value = ID.Text;
daData2.InsertCommand.Parameters.Add("@documentName", SqlDbType.NVarChar).Value = item.Text;
daData2.InsertCommand.Parameters.Add("@extension", SqlDbType.NVarChar).Value = extension;

cs.Open();
daData2.InsertCommand.ExecuteNonQuery();
cs.Close();

}

}
else
{

}

and the problem is when I am saving files from different folders, it seems that saved path in FileInfo remebers only the last

added file to listview (listOfLoadedFiles), and when I click Save button, i get error on line

long DocFileLength = f.Length; that file couldn't be found

any help, thank you

Posted 20-Nov-13 22:21pm

shonezi

Add a Solution

2 solutions

Solution 1

In your code that (I think) gets a directory path, and reads all the files in it: you are creating, and using, all the variables each time the 'foreach loop executes its inner code. So you "throw away" the contents of the byte array 'DocData, except for the last time the loop executes. I think that's probably the source of your problem.

Posted 20-Nov-13 22:37pm

BillWoodruff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-11-20T22:38:00

Solution 2

Before we look at that, and try to sort it out, what are you trying to do? You do realize that your ReadDoc method will return the data for the last file it finds in the folder you specify? So if there are six files, it will read them all, and return the final one - whichever that happens to be in the system your app is running in? And that there is a very good chance that it will fail for access denied reasons on a huge number of folders?
And that if you pass a filename as your code implies, it will fail anyway? And if it's a path, then your extension info will be wrong?
And that it could be replaced by File.ReadAllBytes if you specify the file you want to read rather than a path?

See OP comments below with code

Ok, so the ListView has individual file names in it?
So each ListViewItem is a single file, complete with it's path.
To read the file content:

C#

foreach (ListViewItem item in listOfLoadedFiles.Items)
    {
    string path = item.Text;
    if (!string.IsNullOrWhiteSpace(path) && File.Exists(path))
        {
        byte[] data = File.ReadAllBytes(path);
        long length = new FileInfo(path).Length;
        string extension = Path.GetExtension(path);
        ... continue and write the file to SQL.
        }
    }

And dump the ReadDoc method completely!

Posted 20-Nov-13 22:38pm

OriginalGriff

Updated 21-Nov-13 0:07am

v2

Comments

shonezi 21-Nov-13 5:24am

thank you Griff, you are right with all your questions. how can I change my ReadDoc code (please help me, I am in dead end)

OriginalGriff 21-Nov-13 5:35am

What are your trying to pass to it, and what are you trying to do with that?
If you are trying to pass a specific file path, then DirectoryInfo is not much use.

(Sounds vague, I know - but remember I can't see your screen, so if you don't tell me I have to guess)

shonezi 21-Nov-13 5:47am

you right, ok, this is what I am trying to do

I am saving files to sql server,

I have a form with btnSave, listview (listOfLoadedFiles), btnLoadFiles, folderbrowserdialog,

on btnLoadFiles click event I have this code, which works

openFileDialog2.InitialDirectory = System.Environment.GetFolderPath(Environment.SpecialFolder.Personal);
openFileDialog2.Title = "Insert document";
openFileDialog2.FileName = "";
openFileDialog2.Filter = "All Files|*.*";

IntPtr hImgSmall; //the handle to the system image list
//IntPtr hImgLarge; //the handle to the system image list
string fName; // 'the file name to get icon from
string fName1;
SHFILEINFO shinfo = new SHFILEINFO();

listOfLoadedFiles.SmallImageList = imageList1;
listOfLoadedFiles.LargeImageList = imageList1;

//openFileDialog1.ShowDialog();

if (openFileDialog2.ShowDialog() != DialogResult.Cancel)
{
listOfLoadedFiles.BringToFront();
listView1.SendToBack();

fName1 = openFileDialog2.SafeFileName;
//Use this to get the small Icon
hImgSmall = Win32.SHGetFileInfo(fName, 0, ref shinfo, (uint)Marshal.SizeOf(shinfo), Win32.SHGFI_ICON | Win32.SHGFI_SMALLICON);

//Use this to get the large Icon
//hImgLarge = SHGetFileInfo(fName, 0,
// ref shinfo, (uint)Marshal.SizeOf(shinfo),
// Win32.SHGFI_ICON | Win32.SHGFI_LARGEICON);

//The icon is returned in the hIcon member of the shinfo struct
System.Drawing.Icon myIcon = System.Drawing.Icon.FromHandle(shinfo.hIcon);

imageList1.Images.Add(myIcon);

//Add file name and icon to listview

listOfLoadedFiles.Items.Add(fName1, nIndex1++);

}
so here I have loaded files to listview and on btnSave need to save them into sql server, when I choose files from same folder everything works fine, because as you said, the path is the same for all files, and the problem you already know

shonezi 21-Nov-13 5:51am

public byte[] ReadDoc(string document)
{
byte[] DocData = null;
DirectoryInfo dirInfo = new DirectoryInfo(document);
foreach (FileInfo f in dirInfo.GetFiles())
{
long DocFileLength = f.Length;
FileStream fs1 = new FileStream(document, FileMode.Open, FileAccess.Read);
BinaryReader br1 = new BinaryReader(fs1);
DocData = br1.ReadBytes((int)DocFileLength);
}

return DocData;

}

private void btnSave_Click(object sender, EventArgs e)
{
if (listOfLoadedFiles.Items.Count != 0)
{
byte[] fileData = null;

foreach (ListViewItem item in listOfLoadedFiles.Items)
{

string extension = Path.GetExtension(item.Text);

fileData = ReadDoc(item.Text);

daData2.InsertCommand = new SqlCommand("INSERT INTO Documents VALUES (@Documents, @patternID, @userID, @documentName, @extension)", cs);

daData2.InsertCommand.Parameters.Add("@Documents", SqlDbType.VarBinary).Value = fileData;
daData2.InsertCommand.Parameters.Add("@patternID", SqlDbType.NVarChar).Value = patternID.Text;
daData2.InsertCommand.Parameters.Add("@userID", SqlDbType.NVarChar).Value = ID.Text;
daData2.InsertCommand.Parameters.Add("@documentName", SqlDbType.NVarChar).Value = item.Text;
daData2.InsertCommand.Parameters.Add("@extension", SqlDbType.NVarChar).Value = extension;

cs.Open();
daData2.InsertCommand.ExecuteNonQuery();
cs.Close();

}

}
else
{

}

shonezi 21-Nov-13 5:52am

that's all the code I have
Load files into listview, and save

shonezi 21-Nov-13 5:54am

openfiledialog instead of folderbrowser, sorry

OriginalGriff 21-Nov-13 6:08am

Answer updated

shonezi 21-Nov-13 6:37am

I did what you suggested but I get only last file in listview added to sql

OriginalGriff 21-Nov-13 6:45am

What does the debugger say? How many times does it go round your foreach loop?

shonezi 21-Nov-13 6:50am

first did I implented the code corectly

if (listOfLoadedFiles.Items.Count != 0)
{

foreach (ListViewItem item in listOfLoadedFiles.Items)
{
string path = item.Text;
if (!string.IsNullOrWhiteSpace(path) && File.Exists(path))
{
byte[] data = File.ReadAllBytes(path);
long length = new FileInfo(path).Length;
string extension = Path.GetExtension(path);

daData2.InsertCommand = new SqlCommand("INSERT INTO Documents VALUES (@Documents, @patternID, @userID, @documentName, @extension)", cs);

daData2.InsertCommand.Parameters.Add("@Documents", SqlDbType.VarBinary).Value = data;
daData2.InsertCommand.Parameters.Add("@patternID", SqlDbType.NVarChar).Value = patternID.Text;
daData2.InsertCommand.Parameters.Add("@userID", SqlDbType.NVarChar).Value = ID.Text;
daData2.InsertCommand.Parameters.Add("@documentName", SqlDbType.NVarChar).Value = item.Text;
daData2.InsertCommand.Parameters.Add("@extension", SqlDbType.NVarChar).Value = extension;

cs.Open();
daData2.InsertCommand.ExecuteNonQuery();
cs.Close();
}
}

}
else
{

}

shonezi 21-Nov-13 6:50am

is this ok?

shonezi 21-Nov-13 7:21am

when I save files from same folder it's ok,all saved, but when saving from different, only the last one in the list is saved

shonezi 21-Nov-13 7:24am

it loops only once

OriginalGriff 21-Nov-13 8:42am

Sorry for the delay - work gets in the way from time to time...

If it loops only once, then the problem is in your ListView - it doesn't have the right number of items. Check the actual Items.Count in your If above the foreach and see how many there are.

BTW: I would use "path" again here:
daData2.InsertCommand.Parameters.Add("@documentName", SqlDbType.NVarChar).Value = item.Text;
It's the same string as item.Text, but it's a little more efficient, and slightly clearer to read.

shonezi 21-Nov-13 8:46am

I placed path where you said already :) thank you , let me try this what you said about listview

shonezi 21-Nov-13 8:49am

I am definitelly doing something wrong, it counts alright, maybe it doesnt loops once, ah man I am frustrated

OriginalGriff 21-Nov-13 8:54am

So: put a breakpoint on the foreach line.
When it hits it, look at the ListView.Items property, and check the count manually. If it's one, then you need to find out why.
If it isn't, then step into the loop and look at the value of path immediately after it is loaded. Looks like a file path? Fine, step on through. Keep stepping until it does something odd! :laugh:
Then tell me what it did... ;)

shonezi 21-Nov-13 9:20am

ok, here it is

foreach (ListViewItem item in listOfLoadedFiles.Items)
{
here it shows all items in listview, count is ok
}

but after this line

if (!string.IsNullOrWhiteSpace(path) && File.Exists(path))
{

HERE IT SHOWS ONLY LAST ITEM

byte[] data = File.ReadAllBytes(path);

long length = new FileInfo(path).Length;

string extension = Path.GetExtension(path);

}

OriginalGriff 21-Nov-13 9:36am

So, before it does the test, look at the value in path - I will assume it isn't empty - and then check that file location. Does the file exist?
Because that test is there to ensure that there is a path, and at the end of it is a valid file. Has something got "lost" in the ListView?

shonezi 21-Nov-13 9:45am

I placed a breakpoint on string path = item.Text; and the it showed only path of the last item in listview???? while on line
if (!string.IsNullOrWhiteSpace(path) && File.Exists(path))\
it showed the path to first item in listview????

aaaaaaaaaaaaaaaaaa

OriginalGriff 21-Nov-13 9:56am

Yes, that's what it's supposed to do: the breakpoint is before the line is executed (so you can look at the variables before they get changed, if they do) If you single step once, it will execute that line.

shonezi 21-Nov-13 11:27am

but how to solve the problem griff

OriginalGriff 21-Nov-13 11:44am

I'm still waiting to hear if the path is valid and there is a file at the end of it! :laugh:
I really, really can't see your screen!

shonezi 22-Nov-13 2:11am

sorry, i wasnt online, had to relax my mind :))) the problem is definitelly in line

if (!string.IsNullOrWhiteSpace(path) && File.Exists(path))

File.Exists(path) to be exact, in that the path gets lost of anything but the last item

but I am gonna run debugger now

shonezi 22-Nov-13 3:06am

griff I was stupid, your code works and it works great, here is what happened, i used in openfiledialog as you can see, a openFileDialog2.SafeFileName and with it I got just the name of the file while path was defined, but when changing location it doesnt work, I changed the openFileDialog2.SafeFileName to openFileDialog2.FileName; and now it works,

only thing is I need to save documentName just as documentName, I don't want all that path to be saved

but YOUR CODE WORKS< AND I AM SORRY FOR MY IGNORANCE

thank you griff (not the first time you helped me, probably not the last :)

OriginalGriff 22-Nov-13 4:17am

You're welcome!
Have you looked at the Path.GetFileNameWithoutExtension method? It returns just the file name, no path, no extension - just the name.

shonezi 22-Nov-13 5:03am

I have done that, found it :) griff thank you, for help and patience

OriginalGriff 22-Nov-13 5:55am

:Grin: