If Else Statement for two different users

Question

0.00/5 (No votes)

See more:

I have a a Textbox_TextChanged Event with a code that will divide the number being entered. In that same TextChange I have the math code to see if the user is a Semester User or Quarter User. In the math code if the user is a Semester User it will divide be a certain number. If the user is a Quarter User it will divide by another certain number. I need another pare of eyes to look and see if the code looks ok. It is not working on my side. Can someone tell me if I have missed something or useing the IF,Else statement wrong?

C#

protected void TextBoxNCC_TextChanged(object sender, EventArgs e)
   {
       SqlConnection con = new SqlConnection(System.Configuration.ConfigurationManager.ConnectionStrings["PasswordConnectionString"].ConnectionString);
        con.Open();

        if (true)
        {
            SqlCommand level = new SqlCommand("Select INST_ID, Calendar from TableCOCINST where INST_ID = '" + TextBoxINST_ID.Text + "'", con);
            level.Parameters.Add(new SqlParameter("INST_ID", TextBoxINST_ID.Text));
            level.Parameters.Add(new SqlParameter("Calendar", TextBoxINST_ID.Text));

            SqlDataReader reader = level.ExecuteReader();
            DataTable dt1 = new DataTable();
            dt1.Load(reader);

            foreach (DataRow dr1 in dt1.Rows)
            {
                int returnedLevel = Convert.ToInt32(dr1[0].ToString());
                int inst_id = Convert.ToInt32(dr1[2].ToString());
                Session["inst_id"] = inst_id;
                    
                if (returnedLevel == Semester)
                {
                    int i = Convert.ToInt32(TextBoxNCC.Text);
                    int j = 168;
                    TextBoxNCCDR.Text = Convert.ToString(i / j);

                }
                else if (returnedLevel == Quarter)
                {
                    int i = Convert.ToInt32(TextBoxNCC.Text);
                    int j = 120;
                    TextBoxNCCDR.Text = Convert.ToString(i / j);
                }
   }

Posted 14-Nov-13 1:59am

Computer Wiz99

Add a Solution

Comments

Tom Marvolo Riddle 14-Nov-13 8:02am

In which part it doesn't work?It show any error?

Computer Wiz99 14-Nov-13 8:05am

Before I debug the code to test it, I have an error that says: "The name 'Semester' does not exist in the current context". And the same for the name Quarter. What did I not do?

Tom Marvolo Riddle 14-Nov-13 8:08am

The value get from db in returnedlevel is semester or quarter am i right?

Computer Wiz99 14-Nov-13 8:09am

Yes.

Tom Marvolo Riddle 14-Nov-13 8:11am

check solution and let me know.

Computer Wiz99 14-Nov-13 8:13am

Jas24, I got the code and changed it but I forgot that Semester and Quarter are not intergers. I have to change them to string.

Tom Marvolo Riddle 14-Nov-13 8:15am

problem solved?

Computer Wiz99 14-Nov-13 8:21am

Not yet. Have a new error. "Operator '==' cannot be applied to operands of type 'int' and 'string'. The error is where the if (returnlevel == "Semester") and the same for Quarter.

Tom Marvolo Riddle 14-Nov-13 8:23am

check my updated answer

Mike Meinz 14-Nov-13 8:09am

You have to declare a variable or constant named "Semester" and a variable named "Quarter" that contains the value that you want to compare against "returnedlevel".

Mike Meinz 14-Nov-13 8:03am

What's not working? Please be specific.
Where is declaration of the value of "Semester" and "Quarter" used in If statements?
Have you used Visual Studio interactive debugger to step through the code to see the value in "returnedlevel" and the values in "Semester" and "Quarter"?

Your SQL Statement should be the following to take advantage of the anti-SQL Injection and performance benefits of parameterized queries.
SqlCommand level = new SqlCommand("Select INST_ID, Calendar from TableCOCINST where INST_ID = @INST_ID", con);

You add a SQLParameter named "Calendar" but never use it in your SQL statement. Why?

Computer Wiz99 14-Nov-13 8:06am

Well that is just it. Semester and Quarter are the values for Calendar.

Mike Meinz 14-Nov-13 8:10am

What does that mean? Please explain in detail.

Computer Wiz99 14-Nov-13 8:10am

I thought it should be but I changed it thinking that was my issue. Thanks.

Mike Meinz 14-Nov-13 8:11am

You have to declare a variable or constant named "Semester" and a variable or constant named "Quarter" that contains the value that you want to compare against "returnedlevel".

Mike Meinz 14-Nov-13 8:16am

This line should be removed:
level.Parameters.Add(new SqlParameter("Calendar", TextBoxINST_ID.Text));
It does nothing for you.

Computer Wiz99 14-Nov-13 8:18am

In my table INST_ID is where the User's ID is, Calendar is the column where the Semester and Quarter are at.

Rahul_Pandit 14-Nov-13 8:05am

Did u notice on which line u r getting error

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tom Marvolo Riddle · Accepted Answer · 2013-11-14T02:11:00

Solution 1

If you get string value from DB.You have to change into string

C#

string returnedLevel = (dr1[0].ToString());

you have to put "" while compare.try this

C#

if (returnedLevel == "Semester")
{
   int i = Convert.ToInt32(TextBoxNCC.Text);
   int j = 168;
   TextBoxNCCDR.Text = Convert.ToString(i / j);

}
else if (returnedLevel == "Quarter")
{
   int i = Convert.ToInt32(TextBoxNCC.Text);
   int j = 120;
   TextBoxNCCDR.Text = Convert.ToString(i / j);
}

or if it is int,
you have to assign a value while declaring variable

Posted 14-Nov-13 2:11am

Tom Marvolo Riddle

Updated 14-Nov-13 2:35am

v3

Comments

Mike Meinz 14-Nov-13 8:14am

Jas24,
I don't think that using Semester and Quarter as literals will work. The OP converts the value retrieved from the database to Int32 before storing it in "returnedlevel" so I expect that Semester and Quarter should be an integer constant.

Tom Marvolo Riddle 14-Nov-13 8:16am

Sorry Mike Meinz.I forget to intimate to convert to string.please See his comments.

Mike Meinz 14-Nov-13 8:18am

When I was in the Navy, my captain used to say "Bad information is the curse of our business". I've been cursed again!!!

Tom Marvolo Riddle 14-Nov-13 8:21am

Is there any mistake by me?

Mike Meinz 14-Nov-13 8:27am

No, your Solution is exactly correct. I voted 5 stars.

Tom Marvolo Riddle 14-Nov-13 8:28am

Thanks and cheers!!!

Computer Wiz99 14-Nov-13 8:46am

I have an error at int inst_id = Convert.ToInt32(dr1[2].ToString());, It says Can not find column.

Computer Wiz99 14-Nov-13 8:28am

No, it was mine. I have been up all night try to fix this. Well, testing it now. Lets see how we did.