How to Abort new thread ?

Question

1.00/5 (1 vote)

See more:

hi programmers

I have an application that contain a timer that creat new thread each 1000 milliseconds

my code here

VB

<pre>
    Private Sub Timer1_Tick(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Timer1.Tick
        Dim t1 As New Thread(AddressOf ex1)

        t1.Start()

    End Sub

Privat Sub ex1()

......  A whole lot of code here   .......

End Sub

Each 1000 milliseconds the timer creat new thread
but this thread still running , after 1 One minute my application stops working and crashes .

How to stop first before creating the other

Posted 20-Sep-13 6:36am

Michael Azzar

Updated 20-Sep-13 7:33am

v2

Add a Solution

Comments

[no name] 20-Sep-13 12:40pm

"How to stop first before creating the other", redesign your application code so you do not have to.

Michael Azzar 20-Sep-13 12:44pm

What is your suggestion for the code

[no name] 20-Sep-13 12:47pm

There is nothing to suggest. I have no idea what "A whole lot of code here" means, what you are doing and I am all out of mind reading potions.

Sergey Alexandrovich Kryukov 20-Sep-13 13:30pm

Is it VB.NET or VB?
—SA

Michael Azzar 20-Sep-13 13:33pm

sorry for my tag ,
it is vb.net

Sergey Alexandrovich Kryukov 20-Sep-13 13:43pm

Then there is a method System.Threading.Thread.Abort to be called from some other thread.
However, I won't recommend it unless I know all the detail, this method can easily be abuse and lead to disaster.
I personally use it, but most members will probably disagree and recommend using cooperative exit: a thread checks up some shared (with the use of lock statement) variable and exit by itself. I think this is ugly, but this is safer. I always prefer Abort, but I do it in a save way...
—SA

cvogt61457 20-Sep-13 13:33pm

In your timer tick, check to see if the thread is running. If it is running, don't start the thread.

Michael Azzar 20-Sep-13 13:37pm

Can you help me how to fulfill this code ??

Sergey Alexandrovich Kryukov 20-Sep-13 14:00pm

"Each 1000 milliseconds the timer creat new thread"... — already a bad idea. You really need to review your code design. How about telling us more detail and explain your ultimate goals? Otherwise no attempts to help can really help you.
—SA

Michael Azzar 20-Sep-13 14:13pm

this is my code

Private sub ex1()
Dim sql as string ="Select * From UpdatTable Where ID =' " & Textbox1.text &" ' "

If con.State() Then con.Close()
con.Open()
Try
Dim cmd As New OleDbCommand(sql, con)
Dim dr As OleDbDataReader
dr = cmd.ExecuteReader()
Dim s As String = ""

While dr.Read
str &= Convert.ToString(dr.Item("UserName")) & vbCrLf
End While
TextBox1.Text = str

Catch ex As Exception
MsgBox(ex.Message)
con.Close()
End Try
con.Close()

End sub

Sergey Alexandrovich Kryukov 20-Sep-13 14:47pm

I would advise you to explain your ultimate goals instead.
—SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2013-09-20T07:49:00

Solution 1

Whatever are you doing, you are doing it badly. Please consider to re-design your application. This is my humble opinion, of course.

Posted 20-Sep-13 7:49am

CPallini

Comments

Michael Azzar 20-Sep-13 14:15pm

This is my code can you tell me how to execute it each 1000 M Seconds

Private sub ex1()
Dim sql as string ="Select * From UpdatTable Where ID =' " & Textbox1.text &" ' "

If con.State() Then con.Close()
con.Open()
Try
Dim cmd As New OleDbCommand(sql, con)
Dim dr As OleDbDataReader
dr = cmd.ExecuteReader()
Dim s As String = ""

While dr.Read
str &= Convert.ToString(dr.Item("UserName")) & vbCrLf
End While
TextBox1.Text = str

Catch ex As Exception
MsgBox(ex.Message)
con.Close()
End Try
con.Close()

End sub