problem in inserting value using combobox

Question

0.00/5 (No votes)

See more:

C#

private void button3_Click(object sender, EventArgs e)
        {
            
            SqlConnection con = new SqlConnection(@"Data Source=.\SQLEXPRESS;AttachDbFilename=C:\Users\imran\Documents\Visual Studio 2010\Projects\CompleteProject\CompleteProject\Garments.mdf;Integrated Security=True;Connect Timeout=30;User Instance=True");
            con.Open();
            SqlCommand cmd = new SqlCommand(" INSERT INTO OrderStyle (OrderNo,ProductId,SizeId,ColorId,Description) VALUES ('" + comboBox1.SelectedItem.ToString() + "','" + comboBox2.SelectedItem.ToString() + "','" + comboBox3.SelectedItem.ToString() + "','" + comboBox4.SelectedItem.ToString() + "','" + textBox1.Text + "')", con);
            cmd.ExecuteNonQuery();
            con.Close();
            displayRecords();

        }

please help anyone i can't able to insert data into database using this code using combobox.

Posted 1-Sep-13 11:34am

aliimran224

Updated 1-Sep-13 12:29pm

Nelek

v2

Add a Solution

Comments

Boipelo 1-Sep-13 17:47pm

ProductId, SizeId, ColorId are int? If so, convert the comboboxes; int.Parse(combobox.SelectedValue), what's your error?

[no name] 1-Sep-13 17:48pm

Okay... so what makes you think that you are unable? Do you get an error of some kind? Why are you using the SQL injection attack waiting to happen code? Why are you not using a parameterized query? Whatever the problem is likely to go away then.

CodeBlack 1-Sep-13 23:49pm

can you post your code of the displayRecords() method ?

Shambhoo kumar 2-Sep-13 1:04am

Whhat is your Error message.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mojtaba Eng · Answer 1 · 2013-09-01T19:06:00

C#

private void button3_Click(object sender, EventArgs e)
        {
            
            SqlConnection con = new SqlConnection(@"Data Source=.\SQLEXPRESS;AttachDbFilename=C:\Users\imran\Documents\Visual Studio 2010\Projects\CompleteProject\CompleteProject\Garments.mdf;Integrated Security=True;Connect Timeout=30;User Instance=True");
            con.Open();
            SqlCommand cmd = new SqlCommand(" INSERT INTO OrderStyle (OrderNo,ProductId,SizeId,ColorId,Description) VALUES (@OrderNo,@ProductId,@SizeId,@ColorId,@Description)", con);

cmd.Parameters.Add(@OrderNo,SqlDbType.Int);
cmd.Parameters.Add(@ProductId,SqlDbType.Int);
cmd.Parameters.Add(@SizeId,SqlDbType.Int);
cmd.Parameters.Add(@ColorId,SqlDbType.Int);
cmd.Parameters.Add(@Description,SqlDbType.NVarChar);
cmd.Parameters["@OrderNo"].Value=int.Parse(comboBox1.SelectedValue.ToString());
cmd.Parameters["@ProductId"].Value=int.Parse(comboBox2.SelectedValue.ToString());
cmd.Parameters["@SizeId"].Value=int.Parse(comboBox3.SelectedValue.ToString());
cmd.Parameters["@ColorId"].Value=int.Parse(comboBox4.SelectedValue.ToString());
cmd.Parameters["@Description"].Value=textBox1.Text;

            cmd.ExecuteNonQuery();
            con.Close();
            displayRecords();
 
        }