I can not Insert into DataBase

Question

1.00/5 (2 votes)

See more:

I want insert string entry textbox into my database, but error:

C#

SqlConnection conn = new SqlConnection(@"Data Source=.;Initial Catalog=QLSV_LogIn;uid = sa; pwd = 123456");

private void btnCap_nhat_Click(object sender, EventArgs e)
{
    try
    {
        if (txtKhoa.Text == "")
        {
            MessageBox.Show("Empty","Eror 1");
            txtKhoa.Focus();
        }
        else
        {
            conn.Open();
            SqlCommand cmd = new SqlCommand("Insert Into tblKhoa (TenKhoa) Value('" + txtKhoa.Text + "')", conn);

            cmd.ExecuteNonQuery();

            MessageBox.Show("Success");

            conn.Close();

            txtKhoa.Text = "";
            txtKhoa.Focus();
        }
    }
    catch
    {
        MessageBox.Show("Error 2");
    }
}

when i insert, it show Error 2??? Why??? Help me

Posted 19-Jun-13 21:08pm

Nguyễn Quang Nghĩa

Add a Solution

5 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Pheonyx · Answer 1 · 2013-06-19T21:19:00

Solution 1

Change:

C#

catch
            {
                MessageBox.Show("Error 2");
            }

To

C#

catch (Exception ex)
            {
                MessageBox.Show(ex.tostring());
            }

And tell us what the error is!

Posted 19-Jun-13 21:19pm

Pheonyx

Comments

Nguyễn Quang Nghĩa 20-Jun-13 3:33am

Message: Error in cmd.ExecuteNonQuery();

Pheonyx 20-Jun-13 3:39am

Is that all it says? Does it not give you more details such as issues with the syntax? no open connection etc?

Ravi Kumar Shakya · Answer 2 · 2013-06-20T01:55:00

Solution 5

Replace "Value" to "Values" in this line..

Change this

SqlCommand cmd = new SqlCommand("Insert Into tblKhoa (TenKhoa) Value('" + txtKhoa.Text + "')", conn);

To

SqlCommand cmd = new SqlCommand("Insert Into tblKhoa (TenKhoa) Values('" + txtKhoa.Text + "')", conn);

Posted 20-Jun-13 1:55am

Ravi Kumar Shakya

Updated 20-Jun-13 2:01am

v3

Stephen Hewison · Answer 3 · 2013-06-19T21:22:00

Right a few pointers.

You need to parametrise your try, catch block:

C#

try
{
//Do something
}
catch(Exception ex)
{
//ex contains the error information.
}

Also concatenating the the text value into the command is going to open you up to SQL injection.

If I entered:

GO delete from tblKhoa GO

Into your text box it's possible I could delete all the records from the row.

You should use parameters.

C#

SqlCommand cmd = new SqlCommand("Insert Into tblKhoa (TenKhoa) Value(@MyValue)", conn);
IDbDataParameter param = cmd.CreateParameter();
param.Name = "@MyValue";
param.Type = DbType.String;
param.Value = txtKhoa.Text;
cmd.Parameters.Add(param);

This stop the user including SQL syntax in the text box and cause damage to your database.

KuttiSankar · Answer 4 · 2013-06-19T23:33:00

Solution 3

Instead of calling the Insert command, try to do it in SP, and call it by storedProcedure Method.

Posted 19-Jun-13 23:33pm

KuttiSankar

janaka4595 · Answer 5 · 2013-06-20T00:24:00

Solution 4

catch(Exception ex)
{
throw ex;
}

Posted 20-Jun-13 0:24am

janaka4595