There is a issue with User IDs being inserted into DB for different Users.

Question

0.00/5 (No votes)

See more:

Hi,
I am developing Web Application in which more than one user can login at the same time and do something with database; their we want to use their unique ID to authenticate them.

So how we can hold their unique ID like UserID in Session, we have done like this:

C#

Session["UserID"]=UserID.ToString();

But there is a issue.
While inserting data into DB with their unique IDs, it is replacing their IDs with one another, while logging in from anywhere in the same application.

Please provide solution for the same.

Thanks in adavnce!

Posted 16-May-13 0:31am

Dev Ashish Jangid

Updated 16-May-13 22:31pm

Mohammed Hameed

v4

Add a Solution

Comments

Mohammed Hameed 16-May-13 6:42am

How it will be replaced, actually it shouldn't be. From where you are getting UserID?

Dev Ashish Jangid 16-May-13 7:09am

Hi Mohammed Sir,

When i Check User Name and Password, we get UserID of that user from DB after successfully authentication...

Mohammed Hameed 16-May-13 7:19am

Okay, can you tell me what's the actual type of UserID?

Dev Ashish Jangid 16-May-13 7:32am

can you ask about its datatype...?
its Bigint in DB..

BobJanova 16-May-13 7:15am

Using the user name or ID as a key and storing that in the session is fine. It's more likely that your database query is at fault if you are having trouble in that area.

Mohammed Hameed 16-May-13 7:18am

Yes, thats true...query could be having issue.

Dev Ashish Jangid 16-May-13 7:37am

Thnku for Rply sir,

sir my probleme is like..
if you and me are two users...and you login first and u can ready to insert some data into database and exactly the same time before your inserting i m login and than you can insert the data than the your record is insert with my UserID...

Mohammed Hameed 16-May-13 7:57am

See in ideal case it will never happen.
But anyhow I think there is certainly some issue is there;
1. May be that's at your DB side: Like UserID column is not unique key and hence duplicate user IDs are being created in your table. Due to which this login problem occurs.
2. OR may be there is some issue within your app code like you might have used static keyword.
So verify these two things thoroughly & let me know....

Dev Ashish Jangid 17-May-13 3:07am

yes Mohammed sir exactly i m taking UserID as a static....

Now m deleting this keyword and take it normaly but here i have to detect UserID in also Submit_Button Code from there Session...

hope its work...

BobJanova 16-May-13 10:21am

You should be submitting a new record as an atomic query. 'insert into table (userid, data) values (@UserID, @data)' cannot mix up user IDs and data. What are you actually doing in your insert process?

Dev Ashish Jangid 17-May-13 3:15am

sir my insert query is like...

insert into TbName(user_id,data_1,data_2) values(@UserID,@data1,@data2)

i think it well worked...but i m using UserID as a static on my .cs page so i think its the reason of my problem..

now i m change my code and waiting 4 the output...

Mohammed Hameed 17-May-13 3:33am

Good. Yes remove the static keyword...

Mohammed Hameed 17-May-13 4:23am

Let me know whether it's been resolved or not. Also note that I have modified your question a little bit for understanding purpose.

If any queries do let me know.

Dev Ashish Jangid 17-May-13 5:40am

Thnx to modify the question sir i think its more near to my problem..

BobJanova 17-May-13 4:56am

You said you put it in the session. That is entirely different from a static field!

Mohammed Hameed 17-May-13 5:19am

No. You have to store your non-static variable into a session for accessing it in other pages also.
Now tell me whether you have removed static from your variable and tried; and whether its working fine atleast now or not?

Dev Ashish Jangid 17-May-13 5:21am

Yes sir i m putting it in Session at the Login page (After successfully login) but at the home page where we want that userid we have it Static at declaration time and take the UserID from Session in the (!IsPostBack) Code so that why i think it modify all the time maybe...

BobJanova 17-May-13 5:39am

:facepalm:

Do you know what 'static' means (particularly in the context of a web app)? It means that there is one copy of the data for the whole application! So of course it will overwrite it whenever someone visits the page!

You should almost never use a static variable in a web app. The scope of that field is basically undefined, as it is global across a particular instance of the app, but you have no control over when the app is started and stopped, or whether it will be sharded, so you never actually know how many users are sharing a static.

Just read it out of the session whenever you need it (or put it in a method-local variable if that makes sense).

Mohammed Hameed 17-May-13 6:01am

Thanks a lot Bob for explaining him about static usage.
Yes, I totally agree with the Bob.
Ashish atleast now it should be clear to you. So simply remove static and retrieve user ID from session object wherever needed to resolve this issue permanently.

Dev Ashish Jangid 18-May-13 5:15am

Ya Now Its working....Thanku to both of you Mohammed Sir & BobJanova Sir 4 valuable help

Mohammed Hameed 18-May-13 5:22am

Good to hear that. Ashish I have posted it as Solution, I think you should accept it, as it has resolved your issue, so that other guys who get the same issue may be benifited with it.

2 solutions

Solution 1

Session already is per user, that is handled by IIS. Each time a user connects they get a unique session and you do not need to code for it.

Posted 16-May-13 6:20am

ZurdoDev

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mohammed Hameed · Accepted Answer · 2013-05-17T23:21:00

In ideal case this issue should not happen.

But anyhow I think there is certainly some other issue is there;

1. May be that's at your DB side: Like UserID column is not unique key and hence duplicate user IDs are being created in your table. Due to which this login problem occurs.
2. OR may be there is some issue within your app code like you might have used static keyword.

So verify these two things thoroughly & let me know....