Class library not functioning properly

Question

0.00/5 (No votes)

See more:

hello guys... im trying to write a class library inwhich I handle two different connections to two different DBs. Here is some of the library code...

SqlConnection myConnection1,myConnection2;
public bool OpenAdminConnection()
{
    myConnection1 = new SqlConnection("Data Source=muze-pc\\SqlExpress; Initial Catalog=adminDB; Integrated Security=SSPI");
    try
    {
        myConnection1.Open();
        SetData(); //a function used, working properly
        return true;
    }
    catch(Exception e)
    {
        myConnection1.Close();
        return false;
    }
}
/////////////////////Second connection to 2nd DB
public void OpenTracksConnection()
{
    myConnection2 = new SqlConnection("Data Source=muze-pc\\SqlExpress; Initial Catalog=MusicDB; Integrated Security=SSPI; MultipleActiveResultSets=True");
    try
    {
        myConnection2.Open();
    }
    catch (Exception e)
    {
        myConnection2.Close();
    }
}

public int GetTotalRows()//returns number of (already distinct) records
{
    SqlCommand myComm = new SqlCommand("SELECT COUNT(*) FROM Tracks", myConnection2);
    int totalRows = 0;
    SqlDataReader dataReader;
    dataReader = myComm.ExecuteReader();
    while (dataReader.Read())
    { totalRows++; }
    dataReader.Close();
    return totalRows;
}

public void GetTrackData(int TrackId) //returns info about track using key
{
    SqlCommand myComm = new SqlCommand("SELECT * FROM Tracks WHERE TrackID = " + TrackId.ToString(), myConnection2);
    SqlDataReader dataReader;
    dataReader = myComm.ExecuteReader();
    dataReader.Read();
    td.SetTrackData(dataReader[0].ToString(),dataReader[1].ToString(),dataReader[2].ToString());
    dataReader.Close();
}

Now connection1 is owrking properly but when I call GetTrackData(trackId) in my client, it says that no data is present in the dataReader. What can be the reason? thnx

Posted 19-Jan-11 1:46am

AmbiguousName

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Espen Harlinn · Answer 1 · 2011-01-19T01:57:00

public int GetTotalRows()//returns number of (already distinct) records
{
    SqlCommand myComm = new SqlCommand("SELECT COUNT(*) FROM Tracks", myConnection2);    
    int totalRows = 0;    
    SqlDataReader dataReader;    
    dataReader = myComm.ExecuteReader();    
    while (dataReader.Read())
    { 
      totalRows++; 
    }    
    dataReader.Close();
    return totalRows;
}

Returns 1.

Use totalRows = Convert.ToInt32( SqlCommand.ExecuteScalar() );
The query returns the number of rows.

GetTrackData:

if(dataReader.Read()) // Check that you actually got a result
{
  // I'd rather use the GetXXX methods
  td.SetTrackData(dataReader.GetString(0),
         dataReader.GetString(1),
         dataReader.GetString(2));
}

Regards
Espen Harlinn

#realJSOP · Answer 2 · 2011-01-19T01:55:00

Solution 1

Both the GetTotalRows method and the GetTrackData method use the same SqlConnection object. I'm sure one of them should use myConnection1 instead.

Posted 19-Jan-11 1:55am

#realJSOP

Comments

AmbiguousName 19-Jan-11 8:26am

nope...they use same connection i-e myConnection2, because I need number of rows and row data from database2 (not from DB1).

fjdiewornncalwe · Answer 3 · 2011-01-19T15:05:00

Solution 3

This is pretty much an "is it plugged in" type of answer, but I think it needs to be asked.

When you call

C#

public void GetTrackData(int TrackId)

while testing have you ensured that a record in the Tracks table actually exists with that value?

Posted 19-Jan-11 15:05pm

fjdiewornncalwe