What method should i use to allocate memory in windows Multithread

Question

1.00/5 (1 vote)

See more:

As the title，i use malloc in a windows thread（created by CreateThread API） and free it in calling function which call the CreateThread function and it works fine first. But when i started a new thread , it throws a access exception. And in Debug mode it has no problem the same as debug the release version but running the release version it throws the exception.

Posted 18-Apr-13 17:24pm

Keanu L

Add a Solution

Comments

Mohibur Rashid 18-Apr-13 23:28pm

Make sure you are not using more than you have allocated, it happens mostly with arrays, if you try to delete memory which has been deleted already will also trouble you. so far that's all I can recall that bugged me

nv3 19-Apr-13 2:20am

Without any code and just by the rough description you gave, it will be difficult to help you.

Malli_S 19-Apr-13 3:21am

It would be easy if you could post the thread function.

Kucera Jan 19-Apr-13 9:56am

Dear "friend",

next time it would be pollite to ASK before you start to "reconstruct" my articles/answers.
E.g. you completely changed the meaning of "Pattern II." of my answer. Further, the code was not buggy... maybe you just have to modify it a bit before you use it, thats all.

Next time, discuss before updating OR post your own answer.

Regards,
J. K.

Malli_S 22-Apr-13 2:26am

Yup. :D Sure dear.

You're right, I missed CPallini's 5 point this way. Should I restore the ans? Or you happy with the points?

Kucera Jan 22-Apr-13 3:11am

Hi,

thanx for reply. If I can ask you, restore my answer - if possible. In case you insist ojn your answer, put it as a comment or create a new answer or just append your answer to mine.

thanx in advance
J. K.

Malli_S 22-Apr-13 3:32am

It seems that you're concerned about "your" answer, rather than the "solution to the question".
And I suggest to keep your intention towards 'Solution to the question', rather than what you answer.

You should accept the change, avoid the mistakes, learn from it and move on by adding into your knowledge. Don't stuck into your/my answer.

Sorry dear, I can't restore your ans. Have a nice day.

Note:- Don't take it personally.

Philippe Mori 19-Apr-13 18:48pm

If it does not works, then your code is wrong but since there is no code, we cannot help you. If you use appropriate function at appropriate time using appropriate synchronisation and you properly match allocation and desallocation and properly initiaslize your variable then everything would works fine.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Kucera Jan · Accepted Answer · 2013-04-18T20:41:00

Hi,

what you described is simply a bad design. You shall no malloc the ThreadFunction and free the memeory in the calling function as you described. This can cause problems especially in multithreaded applications. Instead you shall use the following pattern:

Pattern I.
- use malloc to allocate memory in the calling thread.
- then pass the pointer to the allocated memory to the newly created thread (I suppose the new thread fill some data in it, or so)
- after the thread finishes, in the calling thread use the data that hase been stored in the memory.
- finally, by using synchronization method in the calling thread check for the exit of new thread. Deallocate the memory if it has exited.

Pattern II.
- Leave memory handling to newly created thread. The newly created thread will allocate the required memory and release it before exiting.

If the memory shall be shared among all threads, then you need to allocate the memory before creating the threads and release it after all the threads have finished (you have to use the thread synchronization mechanism). Be aware that you need to synchronize the threads with some thread synchronization mechanism !

Every time you must make sure that:
- for every malloc you call free
- for every new you call delete
- for every new[] you call delete [].

Hope this helps.

Best regards,

J. K.

[Updates: Restructured the entire answer. Removed buggy code and added new stuff as well.]