How can I split this by whitespaces. (the first lines is its header)

Question

0.00/5 (No votes)

See more:

Image

I have tried this code but error "index out of range" at cbay.ABS = columnsC[5] because the second line return only 4 instead of 6 elements like in 1st line. I want the 2nd line also return 6 elements.

C#

using (StringReader strrdr = new StringReader(strData))
{
    string str;
    while ((str = strrdr.ReadLine()) != null)
    {
        //  str = str.Trim();
        if ((Regex.IsMatch(str.Substring(0, 1), @"J")) || (Regex.IsMatch(str.Substring(0, 1), @"C")))
        {
            columnsC = Regex.Split(str, " +");
            cbay.AC = columnsC[1];
            cbay.AU = columnsC[2];
            cbay.SA = columnsC[3];
            cbay.ABS = columnsC[5];
            // cbay.ABS = str;
        }
    }
}

Posted 29-Mar-13 0:31am

khoirom

Updated 29-Mar-13 0:37am

Menon Santosh

v4

Add a Solution

Comments

Menon Santosh 29-Mar-13 6:38am

please post your string which you want to split and are you reading the string from text file

khoirom 29-Mar-13 6:40am

Yes, it in the "Image" link

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-03-29T00:56:00

Firstly, stop using regexes - they are a sledghammer to crack a very simple nut.
For example, this:

C#

if ((Regex.IsMatch(str.Substring(0, 1), @"J")) || (Regex.IsMatch(str.Substring(0, 1), @"C")))

Can be rewritten as this:

C#

if (str[0] == 'J' || str[0] == 'C')

which is a heck of a lot easier to read!

Secondly, splitting your data is probably not what you want to do: since it is organised in strict columns, I would manuaglly extract the header line, then use substring to extract the data elements: the fact that some elements have only 3 sets of numbers is important, becasue teh column in which the number occurs tells you which part of the data it is: in teh case of your "C" line, the numbers are the AU, SA, and BSS values, not the AC, AU and SA values you would have to assume from the data if you do a crude split operation as you are doing at present.

Use string.SubString in combination with string.Trim to break up your line, then use int.TryParse to give you actual values instead of assuming character values.

khoirom · Accepted Answer · 2013-03-29T18:16:00

thank you very much. I had rewriten like this:

C#

using (StringReader strrdr = new StringReader(strData))
                       {
                           string str;
                           while ((str = strrdr.ReadLine()) != null)
                           {
                               str = str.TrimStart();

                               if (str.Length > 20 && (str[0] == 'C' || str[0] == 'I'))
                               {

                                   cbay.AC = str.Substring(1, 8).Trim();
                                   cbay.AU = str.Substring(9, 5).Trim();
                                   cbay.SA = str.Substring(14,5).Trim();
                                   cbay.ABS = str.Substring(24,5).Trim();


                               }

                               if (str.Length > 20 && str[0] == 'Y')
                               {

                                   cbay.AC1 = str.Substring(1, 8).Trim();
                                   cbay.AU1 = str.Substring(9, 5).Trim();
                                   cbay.SA1 = str.Substring(14, 5).Trim();
                                   cbay.ABS1 = str.Substring(24,5).Trim();

                                  //  'Y' always come after 'C' and 'I',  so break
                                   break;
                               }

                           }


                       }
                       //return;
                       if (String.IsNullOrEmpty(cbay.AC))  cbay.AC  = "0";
                       if (String.IsNullOrEmpty(cbay.AU))  cbay.AU  = "0";
                       if (string.IsNullOrEmpty(cbay.SA))  cbay.SA  = "0";
                       if (String.IsNullOrEmpty(cbay.ABS)) cbay.ABS = "0";

                       if (String.IsNullOrEmpty(cbay.AC1))  cbay.AC1  = "0";
                       if (String.IsNullOrEmpty(cbay.AU1))  cbay.AU1  = "0";
                       if (string.IsNullOrEmpty(cbay.SA1))  cbay.SA1  = "0";
                       if (String.IsNullOrEmpty(cbay.ABS1)) cbay.ABS1 = "0";

                       cbay.totalAU = ( int.Parse(cbay.ABS) + int.Parse(cbay.ABS1)).ToString();

How can I split this by whitespaces. (the first lines is its header)

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0