Trying not to allow numbers like 12121212/34343434 using javascript

Question

5.00/5 (1 vote)

See more:

Hi everyone,
I have tried to code the following in javascript not to allow numbers like 12121212/34343434.
Can anyone please check and let me know where I am going wrong

XML

<HTML>
 <HEAD>
  <TITLE> </TITLE>

 <script type="text/javascript">
  function formValidation(){
  if (validateAllSame()){
  }
  return false;
  }
  function validateAllSame(){

  var y=document.form1.number.value;
  var x = y.substr(0,2);
  for(int i=2;i<=y.length;i+=2){
  if(y.substr([i],2) != x){
  return true;
  }

  }

  return false;
  alert("wrong number");
  }

  </script>

 </HEAD>

 <BODY>
  <form name ="form1" action="" onsubmit="return formValidation()">
  Number:<input type="text" name="number" value="">
  <input type="submit" value="Done">
   </form>

 </BODY>
</HTML>

Posted 10-Mar-13 8:11am

codegirl24

Add a Solution

Comments

[no name] 10-Mar-13 14:15pm

It would appear that you and http://www.codeproject.com/Questions/559638/Javascriptplusvalidationplusnotplustoplusallowplus are working on the same homework assignment. Maybe you could collaborate?

codegirl24 10-Mar-13 14:16pm

yes.. we have come up with the code together but we both are unable to spot out where the problem could be.

[no name] 10-Mar-13 14:24pm

And you think posting the same thing over and over is going to get a better answer? Did either of you debug this? Did they teach about bench checking in any of your classes? Did you bother trying to figure out what the actual output is?

codegirl24 10-Mar-13 14:31pm

We are just learning and we dont mean posting questions just for fun.. we have tried out changing the code trying to arrive at what we are looking for.We assumed people here are helpful and just provide hints to improve the code.Moreover for people who are learning something new every little thing can be doubtful to attempt..If by just commenting on people's questions/making fun of them/trying to speak in a dominating way you are getting more points..please look for some other persons question.We are looking for someones help here and your comments are no help to us.

enhzflep 10-Mar-13 15:38pm

If ThePhantomUpvoter's questions are of no use to you, you're probably better-off just skipping class for something you consider more interesting. They are basic questions for which you should have answers. If you can't infer what actions to perform in order to fix the code, address the points individually and ask further questions.

Since your question is rather loosely defined, I'll break it down how I see it.

1. We have to input a number from the user
2. We have to check the number to ensure that it meets the following criteria
(a) The number has an even number of digits, the number comprises a repetition of the first two digitis
(b) The number must not contain sequences of (N,N+1)
3. How would I achieve 2a or 2b (You decide which is the accurate definition of a prohibited number - you've not defined what it is about the numbers that may be used to test for them)

If your definition fits (a), then it's easy -
(1) Convert number to a string
(2) Check if string has an even number of digits
(3) get first two digits into a new string
(4) extract next pair of digits
(5) compare to result obtained in (3)
(6) if (reached end of string == 0) && (result #3 == result #4) goto 4

enhzflep 10-Mar-13 15:26pm

It's reasonably often that I'd like to be able to upvote comments. This is another one of them.

codegirl24 10-Mar-13 16:05pm

Thanks for the suggestions.. I wasn't trying not to answer any further questions over my problem..But being a member it would be nice to be asked about anything in a much better tone..One of my friend too tried posting questions and ThePhantomUpvoter tried questioning rudely and was not providing any help for the problem we were facing..
Thanks again for the solution too..I will try out with this option too.

Marco Bertschi 10-Mar-13 17:04pm

Chill down man. Of course it was not a well-asked question. But there was a sample code - which means they have tried to resolve it. This is the thing about the Q&A section.
People ask questions but sometimes they struggle a bit. It was their first question so who wonders that they struggled in asking it?

I am sure they will do better the next time.

cheers,
Marco Bertschi

[no name] 10-Mar-13 18:46pm

Just because there is sample code does not mean that they tried anything at all to solve their problem themself. It is not at all unreasonable to request posters to submit what they have tried.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

codegirl24 · Accepted Answer · 2013-03-10T09:58:00

Solution 1

Hi all,
I found the solution using a regular expression. Hope it would be helpful to anyone facing the same problem.Following is my function code...rest code is same as above.

C#

function validateAllSame(){
  var newregex=/([0-9]+?)\1+/;
  var y=document.form1.number.value;
  
  if((!(newregex.exec(y))) ){
  return true;
  }
  alert("wrong number");
  return false;
  }

Posted 10-Mar-13 9:58am

codegirl24

Comments

Maciej Los 10-Mar-13 16:07pm

Bravo codegirl24!
+5!

Marco Bertschi 10-Mar-13 17:00pm

Good and useable solution. Have +5.