Problems with this php code

Question

0.00/5 (No votes)

See more:

Hello , this is my code to download files with php , but , when I download a file (for example Excel 2007 file) excel doesn't open it. Where is the problem

PHP

$document = urldecode($_GET['download']);
	$extension = end(explode('.',$document));
	$mimetype = '';
	
	switch($extension){
		case 'zip':
		$mimetype='application/zip';
		break;
		case 'rar':
		$mimetype='application/x-rar-compressed';
		break;
		case 'xls':
		$mimetype='application/vnd.ms-excel';
		break;
		case 'xlsx':
		$mimetype='application/vnd.openxmlformats-officedocument.spreadsheetml.sheet';
		break;
		case 'doc':
		$mimetype='msword';
		break;
		case 'docx':
		$mimetype='application/vnd.openxmlformats-officedocument.wordprocessingml.document';
		break;
		case 'ppt':
		$mimetype='application/vnd.ms-powerpoint';
		break;
		case 'pptx':
		$mimetype='application/vnd.openxmlformats-officedocument.presentationml.presentation';
		break;
	}
	header('Content-type:' . $mimetype);
	header("Content-Disposition:attachment;filename:download.". $extension);

  	readfile($document);

Posted 7-Sep-12 8:20am

Hysen Ndregjoni

Add a Solution

Comments

Sergey Alexandrovich Kryukov 7-Sep-12 14:38pm

Can Excel open such file before it was up-loaded? How do you know the files stored on server are correct, of the compatible version, etc.?
--SA

Hysen Ndregjoni 7-Sep-12 15:29pm

they worked before I uploaded , but I will check if there is a problem with the file's name
Thanks!
Hysen Ndregjoni

Sergey Alexandrovich Kryukov 7-Sep-12 16:24pm

Well, can you download one of these files manually, using some available browser (if this is HTTP or HTTPS) or available FTP client (if the URL if FTP) and see if you can do it and the file is valid? This way, you can find out, if your client part code is responsible for a problem or not.
--SA

TRK3 7-Sep-12 16:54pm

Upload a file, then download it. Then do a diff of the two files to see what is different.

Hysen Ndregjoni 7-Sep-12 16:23pm

I checked it , but this happens again

Sergey Alexandrovich Kryukov 7-Sep-12 16:24pm

Not clear what happens. Please see my comment above...
--SA

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mohibur Rashid · Answer 1 · 2012-09-07T12:38:00

Solution 1

Here is simple issue you should know.

even a single space would destroy the file. here is an example below:
example:

C++

<?php
//actually the line before <?php is a new line
file_dowloading_process();
?>

what is wrong in the above example? a new line at the beginning of the code. even if there is any new line or space is available it will destroy the file. so, remove all other useless echo or pure html lines and also if you are dealing with UTF-8 use UTF-8 file without BOM

Posted 7-Sep-12 12:38pm

Mohibur Rashid

Updated 7-Sep-12 16:08pm

v2

Comments

enhzflep 8-Sep-12 0:19am

My 5 for explaining the problem with whitespace. Not the issue here, since doing so will prevent the modification of headers - which will show an error message as well as a dump of the file on screen in the browser, but an important point nonetheless.

Mohibur Rashid 8-Sep-12 1:15am

thanks a lot :)

Hysen Ndregjoni 8-Sep-12 10:11am

thanks

enhzflep · Answer 2 · 2012-09-07T18:38:00

I've used this _very_ simple code. The file works just fine after being downloaded. I also note that your 2nd last line appears to be incorrect. You should have an equals [=] symbol after filename, not a colon[:]

PHP

<?php
	header('Content-type: application/vnd.openxmlformats-officedocument.spreadsheetml.sheet');
	header('Content-Disposition: attachment; filename=download.xlsx');
	readfile('aria.xlsx');
?>

I note that it still functions when we comment-out the first line:

PHP

<?php
	// header('Content-type: application/vnd.openxmlformats-officedocument.spreadsheetml.sheet');
	header('Content-Disposition: attachment; filename=download.xlsx');
	readfile('aria.xlsx');
?>

If you don't have it already, you should _really_ consider downloading the *enhanced* version of the php manual. It's the same as the regular version, albeit with the user contributions that you get on the website. It's about 6 or 7 meg of user examples and notes. It's light-years in front of the standard version.
You can get it here: Select mirror for php_enhanced_en.chm[^]