Better code for stored procedure?

Question

1.00/5 (1 vote)

See more:

SQL-Server-2005

hi here is my sp to get details from two tables

SQL

create PROCEDURE [dbo].[usp_GetCategoryByID1]
@ID int
AS BEGIN
select  tblCategory.*,tblContractType.*
From tblCategory left outer join tblContractType on tblCategory.catContractTypeID=tblContractType.cttContractTypeID
 and tblContractType.cttisDelStatus='0'
where catID=@ID and tblCategory.catisDelStatus='0'
 END

and i want to alter this sp i want to add one more table to get details

tblCategorySub

and @ID=subcID..can any one suggest me how to join in this sp..

thanks

Posted 6-Jul-12 18:55pm

ythisbug

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

AshishChaudha · Answer 1 · 2012-07-06T19:33:00

To alter your procedure use Alter keyword and how do we know your table structure and relation??

SQL

Alter PROCEDURE [dbo].[usp_GetCategoryByID1]
@ID int
AS BEGIN
--Write your sql query here..

select  tblCategory.*,tblContractType.*,tblCategorySub.*
From tblCategory left outer join tblContractType on tblCategory.catContractTypeID=tblContractType.cttContractTypeID 
--here I added (change your table name according to your table structure and relation)
inner join tblCategorySub on tblCategory.subcID= tblCategorySub.subcID
--upto here
 and tblContractType.cttisDelStatus='0'
where catID=@ID and tblCategory.catisDelStatus='0'

 END

Arul R Ece · Answer 2 · 2012-07-06T20:18:00

Hi ..

Please try the below query .

SQL

Alter  PROCEDURE [dbo].[usp_GetCategoryByID1]
@ID int
AS BEGIN
select  tblCategory.*,tblContractType.*
From tblCategory left outer join tblContractType 
on tblCategory.catContractTypeID=tblContractType.cttContractTypeID
join tblCategorySub on tblCategorySub.subcID =tblCategory.catContractTypeID
 
and tblCategorySub.@ID=subcID
 and tblContractType.cttisDelStatus='0'
 
where catID=@ID and tblCategory.catisDelStatus='0'
 END

Vasim889 · Answer 3 · 2012-07-07T01:42:00

SQL

select  tblCategory.*,tblContractType.*
From tblCategory 
 left outer join tblContractType on (tblCategory.catContractTypeID=tblContractType.cttContractTypeID)

left outer join tblCategorySub  on 
(tblCategorySub.ID=tblCategory.subid)

where catID=@ID and tblCategory.catisDelStatus='0' and  tblContractType.cttisDelStatus='0'

Better code for stored procedure?

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0