Better code for stored procedure?

Question

0.00/5 (No votes)

See more:

SQL-Server-2005

hi i want to get details from four tables.and display it in their related field while i save the same record.

this is my sp to get details

SQL

ALTER PROCEDURE [dbo].[usp_GetTPR1Details]
@DID varchar(10),
@DocType varchar(4)
AS BEGIN
Select * from tblStockDetails,tblStockHeader,tblTender,tblBidTree where btDID=@DID and btDocType=@DocType and sdDID=@DID and sdDocType=@DocType and tndDID=@DID and tndDocType=@DocType and sdDocType='TPR1'
END

here DID and DocType is the Common for tblStockDetails,tblStockHeader,tblBidTree and tblTender..

bt am not getting values can any one suggest me?
thank u

Posted 19-Jun-12 19:59pm

ythisbug

Updated 19-Jun-12 20:00pm

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2012-06-19T20:09:00

Solution 1

Did you mean to add the last bit:

SQL

and sdDocType='TPR1'

Because it makes the parameter redundant:

SQL

and sdDocType=@DocType and

Posted 19-Jun-12 20:09pm

OriginalGriff

Comments

ythisbug 20-Jun-12 2:17am

thanks griff..bt also not getting values

OriginalGriff 20-Jun-12 2:22am

What did you change it to?

ythisbug 20-Jun-12 2:23am

ALTER PROCEDURE [dbo].[usp_GetTPR1Details]
@DID varchar(10),
@DocType varchar(4)
AS BEGIN
Select * from tblStockDetails,tblStockHeader,tblTender,tblBidTree
where btDID=@DID and btDocType=@DocType and sdDID=@DID and sdDocType=@DocType and tndDID=@DID and tndDocType=@DocType

like this i tried

OriginalGriff 20-Jun-12 3:05am

That looks a bit better.
There are two possibilities:
1) Have you tried fully qualifying your fields?
WHERE lblBitTree.btDID=@DID AND tblStockDetails.sdDID=@DID AND ...
2) Have you checked your data to make sure there are matching fields? If not, try reducing the WHERE clause until you do get data, then slowing increase until you don't. That would at least give you an idea where to look to find the problem!

ythisbug 20-Jun-12 2:24am

sry i dint understand wat u said